Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
hughes036 created a review comment on a pull request on AllenInstitute/biofile-finder
Does generateFilePath have test cov?
hughes036 created a review comment on a pull request on AllenInstitute/biofile-finder
`envToPrefix` ?
hughes036 created a review comment on a pull request on AllenInstitute/biofile-finder
Looks like this is the pattern for dealing with file properties?
hughes036 created a review comment on a pull request on AllenInstitute/biofile-finder
just formatting?
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
oh yeah I definitely just ported it over from FSS and didnt consider.
kmitcham created a review comment on a pull request on AllenInstitute/biofile-finder
Is supposed to be a date, or a datetime? I thought I saw something about 'bucketing' these values, and it seems like the precision of a datetime is overkill, and a date would be fine. I suppose t...
aswallace opened a pull request on AllenInstitute/biofile-finder
Feature/metadata editing/hide non aics editing
Temporarily remove edit option for non-AICS files until we resolve #391 and #392
aswallace created a branch on AllenInstitute/biofile-finder
feature/metadata-editing/hide-non-aics-editing - An open-use web application created for easy access, collaboration, and sharing of datasets through rich metadata search, filter, sort, and direct viewing in common industry applications or in our web-based 3D Volume Viewer.
aswallace opened an issue on AllenInstitute/biofile-finder
Metadata editing: Warn users when exiting w unsaved changes
When editing metadata in BFF, if the datasource is anything other than AICS (e.g., an uploaded csv or other url), the changes will not persist when the page is closed. We should track when we hav...
aswallace opened an issue on AllenInstitute/biofile-finder
Metadata editing: How to inform users that changes aren't permanent
When editing metadata in BFF, if the datasource is anything other than AICS (e.g., an uploaded csv or other url), the changes will not persist when the page is refreshed or url is shared How sho...
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
This is great, but FWIW lodash can do this whole method in one line for ya: ``` // Splits the fileId into an array where is character is its own element then chunks them into groups of 3 wi...
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
I think it'll be cleaner long-term to keep this out of the properties and instead pass it to a getter method `getLocalPath()` - this would replace the property `localPath` (FWIW `localPath` seen be...
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- add back comment c268675
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- Add unit test for file detail functions c492acc
BrianWhitneyAI created a comment on a pull request on AllenInstitute/biofile-finder
Philip brought up that we could derive from the Cloud path as well which would be much simpler. I opted against this idea since the cloud path is already derived from fms-ID. Open to a discussion h...
BrianWhitneyAI opened an issue on AllenInstitute/biofile-finder
Feature Request: Derive local path from fms ID and show conditionally.
When working with the ETL it became apparent that having an annotation with a unique value for each file puts a lot of stress on the annotation collection. We recently added `local file path` and `...
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- make localPath dependent on eviction bfb0748
pgarrison pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- Fix up local path mount point test e41c9bf
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- insert real fms id 80ae4fb
BrianWhitneyAI opened a draft pull request on AllenInstitute/biofile-finder
feature/derive_local_path
BrianWhitneyAI created a branch on AllenInstitute/biofile-finder
feature/derive_local_path - An open-use web application created for easy access, collaboration, and sharing of datasets through rich metadata search, filter, sort, and direct viewing in common industry applications or in our web-based 3D Volume Viewer.