Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
wise-king-sullyman created a review on a pull request on TheOdinProject/curriculum
Seems like a good change, thanks!
wise-king-sullyman created a branch on patternfly/patternfly-doc-core
create-cli - Core documentation templates, helpers, and scaffolding for generating sites based on PatternFly.
wise-king-sullyman pushed 1 commit to main patternfly/pf-codemods
- fix: type getVariableValue helper (#796) * fix: type getVariableValue helper * feat(helpers): isEnumValue and prope... 3bacbc6
wise-king-sullyman closed an issue on patternfly/pf-codemods
getAttributeValue helper return type is implicitly any, which has caused at least one error throwing bug
We should give it an explicit type that more accurately reflects the return value, as it doesn't really _need_ to be `any`.
wise-king-sullyman closed a pull request on patternfly/pf-codemods
fix: type getVariableValue helper
Closes #790, #630 I had to add some new helpers to simplify proper type checking.
wise-king-sullyman pushed 28 commits to v6 wise-king-sullyman/insights-chrome
- Use generated search index cbea8ff
- Use generated fed-modules.json d99cd66
- Use generated navigation files. 64ffe00
- Merge branch 'master' into townhall-feo-demo ecd0692
- Merge branch 'master' into townhall-feo-demo e98637f
- Update README.md for running locally 8941822
- Update README.md 2a166e6
- Update README.md 3a97495
- Merge pull request #2983 from adonispuente/patch-1 Update README.md for running locally dccba35
- chore(deps): update quay.io/redhat-appstudio/build-trusted-artifacts:latest docker digest to ff35e09 Signed-off-by: ... b1a60dd
- Global filter to use 'Reset filters' instead of 'Clear filters' 20a2ad3
- Merge pull request #2986 from leSamo/clear-filters Global filter to use 'Reset filters' instead of 'Clear filters' cb3a57e
- chore(deps): update konflux references Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.... 093939c
- Merge pull request #2984 from RedHatInsights/konflux/references/master chore(deps): update konflux references dea104c
- Merge branch 'master' into konflux/mintmaker/quay.io-redhat-appstudio-build-trusted-artifacts-latest 3a9ccda
- Merge pull request #2985 from RedHatInsights/konflux/mintmaker/quay.io-redhat-appstudio-build-trusted-artifacts-lates... a65048d
- fix ansible bundle trial redirects 1e569e9
- Merge branch 'master' into ansible-trial a452b7c
- Merge pull request #2987 from Hyperkid123/ansible-trial fix ansible bundle trial redirects 8cb34c7
- add sentry workflow 08c8e07
- and 8 more ...
wise-king-sullyman created a comment on an issue on patternfly/patternfly-react
I agree that the types are conflicting and that's something I do think we should fix, so thank you for making this issue! I am a bit confused though as to what drives the need to pass a generic ty...
wise-king-sullyman created a comment on a pull request on patternfly/pf-codemods
> One question could be what we want to do with things that may not be used elsewhere I agree with us still splitting them out. On the jsdoc stuff I kind of wonder if the param and return des...
wise-king-sullyman created a review on a pull request on patternfly/pf-codemods
Absolutely incredible work on this!
wise-king-sullyman created a review on a pull request on patternfly/patternfly-react
I would _maybe_ rather see us have these examples a bit DRYer, but I could also see a good argument for keeping it as is, so not a blocker.
wise-king-sullyman pushed 1 commit to main patternfly/patternfly-react
- fix(Toolbar): Fix formatting of Stacked example (#11426) * fix(Toolbar): fix formatting of stacked example * move b... ffc6d88
wise-king-sullyman closed an issue on patternfly/patternfly-react
Bug - Toolbar - Stacked example not displaying correctly
**Describe the problem** The Stacked example in Toolbar has no description and instead displays a second heading of 'Untitled example'. **Screenshots** : Fix formatting of Stacked example
<!-- What changes are being made? Please link the issue being addressed. --> **What**: Closes #11425
wise-king-sullyman pushed 1 commit to main patternfly/patternfly-react
- docs(TreeView): add example with unique icon per item (#11377) * docs(TreeView): add example with unique icon per it... 6733ef5
wise-king-sullyman closed an issue on patternfly/patternfly-react
Tree view - ability to specify icon per each element
**Is this a new component or an extension of an existing one?** Extension to existing one **Describe the feature** Ability to specify icon per each element. For now there is no possibility to ...
wise-king-sullyman closed a pull request on patternfly/patternfly-react
docs(TreeView): add example with unique icon per item
Closes #10236
wise-king-sullyman closed an issue on patternfly/patternfly-react
Table component manage column functionality not working
**Describe the enhancement or change** A clear and concise description of the request. What is the expected outcome? **Is this request originating from a Red Hat product team? If so, which ones an...
wise-king-sullyman closed an issue on patternfly/patternfly-react
Remove deprecated DragDrop examples and demos
Update the table drag and drop example to use new drag and drop. Also make sure it is not used anywhere else that is not marked deprecated.
wise-king-sullyman pushed 1 commit to main patternfly/patternfly-react
- feat(Table,misc): rewrite column management demo, remove old dnd examples (#11295) * feat(Table,misc): rewrite colum... b24648d
wise-king-sullyman closed a pull request on patternfly/patternfly-react
feat(Table,misc): rewrite column management demo, remove old dnd examples
Closes #11190. Also slightly touches up the basic column management demo as the changes to Modal are the same. There is an issue with `DragDropSort` I've noticed but haven't yet debugged, tha...
wise-king-sullyman created a review comment on a pull request on patternfly/pf-codemods
Nit: Instead of this casting could you do a typecheck of `val.value.value`?
wise-king-sullyman created a review on a pull request on patternfly/pf-codemods
One small nit, but man this is looking GREAT 🔥
wise-king-sullyman created a review on a pull request on patternfly/pf-codemods
One small nit, but man this is looking GREAT 🔥
wise-king-sullyman created a review comment on a pull request on patternfly/pf-codemods
Shouldn't these dist imports be updated to `dynamic/MissingPageProps`?