Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
svrooij created a comment on a pull request on microsoft/kiota-python
 👀
svrooij created a comment on an issue on microsoft/kiota-python
@baywet maybe we can do this for version 1.8.0 as well?
svrooij created a comment on a pull request on microsoft/kiota-python
It really helps that I'm now able to run all the tests locally in Python 3.9, only 1 error left and that is because an assertion tried to parse a datetime string with a z to compare
svrooij pushed 1 commit to remove-pendulum-dependency svrooij/kiota-python
- Fixing datetime parsing in test 🧪 f1b515f
svrooij pushed 1 commit to remove-pendulum-dependency svrooij/kiota-python
- More 🕑 compatibility 1373232
svrooij created a comment on a pull request on microsoft/kiota-python
@danieleds and strip of the `Z`? ``` FAILED tests/unit/test_json_parse_node.py::test_get_collection_of_object_values - ValueError: Invalid isoformat string: '2021-07-29T03:07:25Z' ```
svrooij pushed 1 commit to remove-pendulum-dependency svrooij/kiota-python
- Hopefully try 50 fixes it 💣 15b5a31
svrooij created a comment on a pull request on microsoft/kiota-python
Going to download a python 3.9 dev container and run the tests there.
svrooij created a comment on a pull request on microsoft/kiota-python
@baywet I only get notifications from reactions (yours and sonarqube)
svrooij created a comment on a pull request on microsoft/kiota-python
> Oh I see. Yes, that's exactly what I had in mind. Something like, in form_parse_node.py and similar files: > > ```python > if sys.version_info[:3] <= (3,10): > fixed_time = re.sub(r'(\d[...
svrooij pushed 1 commit to remove-pendulum-dependency svrooij/kiota-python
- fromisoformat compatibility 8aaeff1
svrooij created a review comment on a pull request on microsoft/kiota-python
Yes ?P is python regex for, this is a named group
svrooij created a comment on an issue on microsoft/kiota-python
This is what I meant... I have no clue about python but this documentation would be useful. Created a devcontainer config that does this and allows your to run all those things from vscode, no int...
svrooij created a comment on a pull request on microsoft/kiota-python
> > To make it not stop working my suggestion is that I make the P optional. > > Ah no, good catch, it's a typo on my end, please add the P, it's mandatory according to the ABNF. Want me to r...
svrooij pushed 1 commit to remove-pendulum-dependency svrooij/kiota-python
- Support additional timedeltas f0ed780
svrooij created a comment on a pull request on microsoft/kiota-python
Got the tests working in a dev container. Down to the last issue. ```plain text = 'T12H59M45S' def parse_timedelta_from_iso_format(text: str) -> timedelta: """Parses a ISO8601 d...
svrooij created a comment on a pull request on microsoft/kiota-python
@baywet I'll try to get it over the finish line, tomorrow.
svrooij created a comment on a pull request on microsoft/kiota-python
This is related to #453 being able to run the tests locally would greatly reduce the developer feedback flow.
svrooij pushed 1 commit to remove-pendulum-dependency svrooij/kiota-python
- Reduce complexity and raise error instead of return none e61eabb
svrooij created a comment on a pull request on microsoft/kiota-python
@baywet is there a command to apply the wanted code formatting? I see it's failing at that.
svrooij opened an issue on microsoft/kiota-python
Lower requirement for urllib and httpx
Are the dependency requirements set in stone? Or can we lower `urllib` and `httpx` to something that works with these package constrains? https://github.com/microsoft/kiota-python/blob/dbda749947f...
svrooij pushed 3 commits to remove-pendulum-dependency svrooij/kiota-python
- fix: bumps pendulum to a stable version Signed-off-by: Vincent Biret <[email protected]> 75b302f
- Merge pull request #449 from microsoft/chore/pendulum-stable fix: bumps pendulum to a stable version dbda749
- Merge branch 'main' into remove-pendulum-dependency f2ad78e
svrooij pushed 1 commit to remove-pendulum-dependency svrooij/kiota-python
- Feedback processed and removed python-dateutil 41d8efd
svrooij created a review comment on a pull request on microsoft/kiota-python
> The timedelta class in Python's datetime module does not enforce faulty combinations like months and weeks. Instead, it computes the expected value based on the provided arguments. The timedelta ...