Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
stratoula created a review comment on a pull request on elastic/kibana
Callback, it is a classic abbreviation.
stratoula created a review comment on a pull request on elastic/kibana
It is a classic EUI component that we use everywhere at kibana 🤔 But @andreadelrio not sure if you have ideas about it?
stratoula created a review comment on a pull request on elastic/kibana
It is not static, it can change to be either value from query or static values (given by the user)
stratoula created a review comment on a pull request on elastic/kibana
I don't see this @Heenawter. Can you help me reproduce it? Did you do anything specific?
stratoula created a review comment on a pull request on elastic/kibana
https://github.com/elastic/kibana/pull/202875/commits/29f82f0db4df3c2d583d92d64ae0bcaaea69d4f9
stratoula created a review comment on a pull request on elastic/kibana
Done here https://github.com/elastic/kibana/pull/202875/commits/29f82f0db4df3c2d583d92d64ae0bcaaea69d4f9
stratoula created a review comment on a pull request on elastic/kibana
This makes sense, addressed here https://github.com/elastic/kibana/pull/202875/commits/29f82f0db4df3c2d583d92d64ae0bcaaea69d4f9
stratoula created a review comment on a pull request on elastic/kibana
But they are available everywhere, not only in the esql api. It is wrong to assume that they are only there when they are available on every control 🤔 (unless I am missing something here)
stratoula created a review comment on a pull request on elastic/kibana
Done https://github.com/elastic/kibana/pull/202875/commits/cbc7001f9171397083ba4f847f94cc07c3af472e
stratoula created a review comment on a pull request on elastic/kibana
Very good catch https://github.com/elastic/kibana/pull/202875/commits/cbc7001f9171397083ba4f847f94cc07c3af472e
stratoula created a review comment on a pull request on elastic/kibana
Done here https://github.com/elastic/kibana/pull/202875/commits/cbc7001f9171397083ba4f847f94cc07c3af472e
stratoula created a review comment on a pull request on elastic/kibana
This creates a different behavior in some cases so I will prefer to keep what I have so far.
stratoula created a review comment on a pull request on elastic/kibana
Hmmm Marco I dont really follow your suggestion here. Can you be more specific por favor?
stratoula created a review comment on a pull request on elastic/kibana
Sure, we do this above too. Let me know of what you are suggesting