Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
schloerke created a comment on a pull request on posit-dev/py-shinywidgets
[Shinylive app link](https://shinylive.io/py/editor/#code=NobwRAdghgtgpmAXGKAHVA6VBPMAaMAYwHsIAXOcpMAMwCdiYACAZwAsBLCbJjmVYnTJM6cKITIcAbnAA6Eeo1aduGOAA9Uoli179BwrqgCuZPE2Md5i5uy7YMo8ZJl6BQpgHM4ZAPq...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
But is it necessary since we're `cast()`ing? I think we might be able to get away with a invariant type. ```suggestion _R = TypeVar("_R", bound=Resource) ``` (`R` for factory _R_ eturn v...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
```suggestion resource: _T_co = self._factory(self._ctx, path, **result) resource = cast(_T, resource) ```
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
```suggestion resource: _T_co = self._factory(self._ctx, path, **result) resource = cast(_T, resource) ```
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
From other repos, I've used an explicit type expectation before casting the value. ```python resource: _T_co = self._factory(self._ctx, path, **result) resource = cast(_T, ...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
```suggestion resource: _T_co = self._factory(self._ctx, path, **result) resource = cast(_T, resource) ```
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
A perfect use case! Linking for my own reminder: https://stackoverflow.com/a/61737894/591574
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
We do not adjust `factory` or `uid`, but their default values are shared objects between instances: https://www.pythonmorsels.com/mutable-default-arguments/ (No changes necessary... just a thoug...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
My preference is to put uncommon args that have defaults behind some sort of "name requirement" mechanism. ```suggestion *, factory: ResourceFactory[_T_co] = _Resource, ```
schloerke created a review on a pull request on posit-dev/posit-sdk-py
Couple typing style requests. One question on the covariant type var.
schloerke created a review on a pull request on posit-dev/posit-sdk-py
Couple typing style requests. One question on the covariant type var.
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
From other repos, I've used an explicit type expectation before casting the value. ```python resource: _T_co = self._factory(self._ctx, path, **result) resource = cast(_T, re...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
I couldn't either... I tried to do this locally before you opened the PR. 😜
schloerke pushed 1 commit to tdstein/import-typing-extensions posit-dev/posit-sdk-py
- Add test to verify no `typing` imports are ever used de67552
schloerke pushed 1 commit to main posit-dev/posit-sdk-py
- refactor: `Tag.update()` should return `None` (#369) 1a2cc55
schloerke closed a pull request on posit-dev/posit-sdk-py
refactor: `Tag.update()` should return `None`
Other changes: * Added `update_dict_values(obj, **kwargs)` to update the dict values of an object from https://github.com/posit-dev/posit-sdk-py/pull/366#discussion_r1887845267 This is the l...
schloerke pushed 5 commits to schloerke/tags_update posit-dev/posit-sdk-py
schloerke closed a pull request on posit-dev/posit-sdk-py
refactor: Use new duck typing for content item `.repository` methods
Related: #364 Other changes: - Remove `_api.py`, `_api_call.py`, `_json.py` files as they are unused - Move to new file to avoid crowding - Use "mixin" to keep all methods close to each oth...
schloerke pushed 2 commits to schloerke/gut_api_files posit-dev/posit-sdk-py
schloerke pushed 2 commits to schloerke/gut_api_files posit-dev/posit-sdk-py
schloerke pushed 3 commits to schloerke/gut_api_files posit-dev/posit-sdk-py
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
`_Resource` has a `.destroy()` method. That should cover it