Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
schloerke pushed 1 commit to schloerke/system-cache-runtime posit-dev/posit-sdk-py
- Use client to retrieve path Co-Authored-By: Taylor Steinberg <[email protected]> edf0675
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
I missed the switch from `.session` to `.client`. 👍
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
Resolved with all other similarly shaped imports
schloerke pushed 1 commit to schloerke/system-cache-runtime posit-dev/posit-sdk-py
- Clean up imports Co-Authored-By: Taylor Steinberg <[email protected]> 08caf8d
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
It doesn't need the full url?
schloerke pushed 2 commits to schloerke/system-cache-runtime posit-dev/posit-sdk-py
schloerke created a comment on a pull request on posit-dev/posit-sdk-py
- [ ] Dry run should return `None`
schloerke pushed 1 commit to schloerke/system-cache-runtime posit-dev/posit-sdk-py
- Only assert cache size on >= 2024.05.0 369d752
schloerke pushed 1 commit to schloerke/system-cache-runtime posit-dev/posit-sdk-py
- Update test_system.py 00bdda6
schloerke pushed 1 commit to schloerke/system-cache-runtime posit-dev/posit-sdk-py
- Fix skip logic location 38a5c5d
schloerke pushed 1 commit to schloerke/system-cache-runtime posit-dev/posit-sdk-py
- Only test caches length when connect versions >= 2023.05.0 6f5c3e3
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
Can we replace it with the pyright ignore command? `# pyright: ignore[RULE]` (And if it's only parameter specific, can we put it on an isolated line only? Thank you!)
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
Should this class inherit from `Sequence[T]` and we replace the `Any` types below with `T`? This might replace the need for a `_GetItem` class : https://github.com/posit-dev/posit-sdk-py/pull/35...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
Is it possible to suffix the class names with `P` to help visually declare that it's a protocol class? ```suggestion class _PackagesP(Sized, Protocol): ``` (Much easier to perform with "ren...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
Is it possible to put this into a generic helper class? ```python class _GetItem(Sized, Generic[T], Protocol): @overload def __getitem__(self, index: SupportsIndex) -> T: ... @...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
```suggestion def __getitem__(self, index: slice) -> list[_ContentPackage]: ... ```
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
```suggestion $(UV) run pytest -s --junit-xml=./reports/$(CONNECT_VERSION).xml | \ ```
schloerke created a review on a pull request on posit-dev/posit-sdk-py
So much deletion. This is awesome!
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
Same applies to `.update()`, `.create()`, and `.find_by()` below
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
I'm ok with keeping the `.update()` as is. I'd like to make a followup PR to revert Task.update and `ContentItemRepository.update`
schloerke pushed 1 commit to main rstudio/shiny-workflows
- ci: Use cache GHA restore/save for PhantomJS (#40) affe3d0
schloerke closed a pull request on rstudio/shiny-workflows
ci: Use cache GHA restore/save for PhantomJS
Original 2x warnings per job ``` Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/...