Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
schloerke pushed 1 commit to schloerke/338-revoke-content-item-permissions posit-dev/posit-sdk-py
- simplify docs. Add note about silently ignoring perms not found 2ce66b3
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
Correct, mismatches will be silent. I'll add that to the docs. I'd like to not submit warnings if possible. My interpretation is that at the end of the function, all associated provided perm...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
I had added them in an earlier PR and Taylor had pushed back. I've come to agree that the type requirements should be relaxed. So yes, unrelated to this PR, but useful.
schloerke pushed 1 commit to schloerke/338-revoke-content-item-permissions posit-dev/posit-sdk-py
- Apply suggestions from code review Co-authored-by: Jonathan Keane <[email protected]> c3261ed
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
In the test file above (integration/tests/posit/connect/test_content_item_permissions.py), I want to use a couple users to test the permissions. So I added them there to have it be self contained. ...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
Added in https://github.com/posit-dev/posit-sdk-py/pull/343
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
My thought was that the deprecations could be gutted when v1 comes out.
schloerke created a comment on a pull request on posit-dev/posit-sdk-py
> I understand that circular reference/dependency is an issue, but could you say more about how/why this particular addition makes us bump into it? Up until now, functions have been fairly isola...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
When you have a user object, the class will appear as "public" information. So when a user types `user. `, the autocomplete will start with objects that have capital letters at top and presents the...
schloerke created a review comment on a pull request on posit-dev/posit-sdk-py
I don't mine the separation because of the strong type support. If there's more situations like this, we can think on moving them together later. (Note, we'll need to maintain the `groups.py...
schloerke created a review comment on a pull request on rstudio/connectapi
These lintr warnings (and R CMD check warnings) should be able to be removed if `.data$content_guid` is used. Related vignette: https://cran.r-project.org/web/packages/dplyr/vignettes/in-packag...
schloerke created a review comment on a pull request on rstudio/connectapi
With `groups` being a _newish_ parameter type, Can we add a small "this is a data frame and has `guid` and `name` columns?" check?
schloerke pushed 1 commit to main schloerke/posit-llm-quickstart
- Remove files that are not needed for app 2db0fc9
schloerke created a comment on a pull request on posit-dev/posit-sdk-py
@jonkeane Looking for approval on the function implementation. I'll add unit testing after #339 is merged and ask again for a review before merging.
schloerke created a comment on a pull request on posit-dev/posit-sdk-py
After conversations with Taylor, we are not going to merge this PR. However, there are good ideas within it. Will keep the PR open until issues are made and/or components pulled out.