Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
samsiegart created a review on a pull request on Agoric/agoric-sdk
LGTM but deferring approval to other reviewers since I'm not sure about the `bankManager` stuff in `fast-usdc.start.js`
samsiegart created a review on a pull request on Agoric/agoric-sdk
LGTM but deferring approval to other reviewers since I'm not sure about the `bankManager` stuff in `fast-usdc.start.js`
samsiegart pushed 1 commit to srs-fu-transfer-cli Agoric/agoric-sdk
- fixup! feat(fast-usdc): detect transfer completion in cli 24ab2c3
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Are they mutually exclusive? I want to use `globalThis` to namespace the global fetch, and have the arg default to that. I guess I'd have to rename it to `fetchArg` or something. But either way, I ...
samsiegart created a comment on a pull request on Agoric/agoric-sdk
> Please use the agoric-sdk PR template with special attention to the Test Plan section. How do we know this will work with Noble ? The issue describes integrating with their x/forwarding accounts....
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Is there a way to assert that it _is_ in the wallet's bank in this test context? I might suggest at least saying 'FastLP balance should be in bank, not in wallet record', or maybe put a `want` in t...
samsiegart opened a draft pull request on Agoric/agoric-sdk
feat(fast-usdc): detect transfer completion in cli
fixes https://github.com/Agoric/agoric-sdk/issues/10339 This just simply polls the USDC balance on the destination account repeatedly to see when it changes
samsiegart created a branch on Agoric/agoric-sdk
srs-fu-transfer-cli - monorepo for the Agoric Javascript smart contract platform
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
> Oh, the evidence isn't stored in a way that it can be looked up for each update. Ah I see, yea not worth changing that part. > I think that's covered by the unit tests I guess that makes...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
I was thinking of including it in all cells so we wouldn't have to track anything but the latest, it's kind of moot if we only include the evidence in the first cell, even though it's one less cell...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Why not unserialize fastUsdc.txns also though? It appears to be capdata from the snapshot: ``` {"body":"#{\\"status\\":\\"ADVANCING\\"}","slots":[]} ```
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
It appears from looking at `status-manager.js` that the evidence is written in the same block as the status https://github.com/Agoric/agoric-sdk/blob/33173f9535005998b7ea7f44aa6ac3b81ba09085/packag...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Question: I'm a bit confused. Below we have: ``` t.deepEqual( storage.getPureData(`fun.txns.${mockEvidence.txHash}`), [mockEvidence, { status: PendingTxStatus.Advancing }], 'tx i...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Optional: It might help to document this a bit. I gather it can't have any remotables or bigints.
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Request: Since this is now capdata and not a plain string, please use https://github.com/Agoric/agoric-sdk/blob/33173f9535005998b7ea7f44aa6ac3b81ba09085/packages/boot/test/fast-usdc/fast-usdc.test....
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Optional: Could we just name this fastUsdc? Is it intentionally different than the real node? Seeing "fun" in the test file was confusing at first.
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
I think in terms of using a CLI it's still easier to have the args. With JSON we lose the handy docs and parsing/type enforcement, and the overall input length is still pretty much the same. If ...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Could you describe more how that would look usage-wise?
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Shouldn't this `map` function return `usedInvitation` for the logic below to work? If it doesn't return anything then `checks.some(Boolean)` would always be false right?