Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
samsiegart created a branch on Agoric/dapp-agoric-basics
srs-fix-amount-input - This is a simple app for the Agoric smart contract platform.
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
> Perhaps make vstorageKit.agoricNames a promise instead of removing it then? I don't think it's necessary to do this. My main concern is that we have a function with two arguments that can be t...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
I thought this PR is about making vstorageKit synchronous. If there's a context where looking at a provided `agoricNames` object contradicts what would result by calling the provided `vstorageKit.r...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
This address is different than the previous `nobleContractAddress`, should we update it in multichain-testing/test/fast-usdc/config.ts as well?
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
It seems a little fickle to inject both `agoricNames` and `vstorageKit` because `agoricNames` should always come from the `vstorageKit`'s queries. Being able to independently craft them allows them...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Question: is agoric.follow deprecated? Just not preferred? Is there a larger pattern of work to replace it with vstorage kit that we should file?
samsiegart created a review on a pull request on Agoric/agoric-sdk
LGTM mostly but please see my non-blocking request to add a comment
samsiegart created a review on a pull request on Agoric/agoric-sdk
LGTM mostly but please see my non-blocking request to add a comment
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
For context: https://developers.circle.com/stablecoins/evm-smart-contracts That's for `cctpTokenMessengerAddress`, but `nobleContractAddress` could be the same or different. From codecider: `...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
I suppose this is reasonable for testing it worked. It would also be good to verify that the pool shares were received, but I think we can do that implicitly in the todo withdrawal test below.
samsiegart created a review on a pull request on Agoric/agoric-sdk
So cool to see this [working](https://github.com/Agoric/agoric-sdk/actions/runs/12267622619/job/34228058901)!
samsiegart created a review on a pull request on Agoric/agoric-sdk
So cool to see this [working](https://github.com/Agoric/agoric-sdk/actions/runs/12267622619/job/34228058901)!
samsiegart created a review on a pull request on Agoric/agoric-sdk
The CI failure looks like it might be related to the changes, will TAL after that's passing
samsiegart created a comment on a pull request on Agoric/agoric-sdk
Updated the pool metrics vstorage path because of https://github.com/Agoric/agoric-sdk/pull/10639
samsiegart pushed 1 commit to srs-lp-cli Agoric/agoric-sdk
- fixup! feat(fast-usdc): cli for lp deposit and withdraw d10cfb9
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Got it, thanks for clarifying.
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Done in spirit, but I made the pool share worth > 1 to test the math/rounding logic of the offer proposal, so it's less than 100_000_000.