Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

samsiegart

samsiegart opened a pull request on Agoric/agoric-sdk
test(fast-usdc): count computrons for advancement
closes https://github.com/Agoric/agoric-sdk/issues/10511 ### Testing ``` ~/agoric-sdk/packages/boot$ SWINGSET_WORKER_TYPE=xsnap yarn test test/fast-usdc/ ... ✔ makes usdc advance (5....
samsiegart created a branch on Agoric/agoric-sdk

srs-measure-fu - monorepo for the Agoric Javascript smart contract platform

samsiegart created a review on a pull request on Agoric/agoric-sdk

View on GitHub

samsiegart created a review comment on a pull request on Agoric/agoric-sdk
That's understandable, it's reasonable to assume this will be run in an environment with agd already. For noble, I didn't want to require nobled, so I added it.

View on GitHub

samsiegart created a review on a pull request on Agoric/agoric-sdk

View on GitHub

samsiegart created a review comment on a pull request on Agoric/agoric-sdk
I guess `env` was introduced at some point. It's not great to have both `env` and a config file that can conflict. I'd ask that we at least make https://github.com/Agoric/agoric-sdk/blob/ef82fbf746...

View on GitHub

samsiegart created a review comment on a pull request on Agoric/agoric-sdk
I guess this is okay for now, would be great if it just went ahead and did the tx. There's an example here of it broadcasting a noble tx: https://github.com/Agoric/agoric-sdk/blob/master/packages/f...

View on GitHub

samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Consider: adding this to a new `testing/helpers.ts` (or similar) file.

View on GitHub

samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Could you please put this in `testing/mocks`? It's better than the existing `mockOut` thing so should be used going forward.

View on GitHub

samsiegart created a review on a pull request on Agoric/agoric-sdk
The changes requested are mostly for the test helpers, but also _consider_ the `env` feedback and broadcasting the txn

View on GitHub

samsiegart created a review on a pull request on Agoric/agoric-sdk
The changes requested are mostly for the test helpers, but also _consider_ the `env` feedback and broadcasting the txn

View on GitHub

samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Hmm good point, I think this would happen in a different block, so maybe measure it separately, but should be counted nonetheless. I can follow up with this.

View on GitHub

samsiegart created a review on a pull request on Agoric/agoric-sdk

View on GitHub

samsiegart created a review on a pull request on Agoric/agoric-sdk
LGTM

View on GitHub

samsiegart created a review on a pull request on Agoric/agoric-sdk

View on GitHub

samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Might as well... the builder script still has a TODO to determine the real addresses but I just arbitrarily removed two of them for now.

View on GitHub

samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Done with `as` (since it's a ts file)

View on GitHub

samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Done

View on GitHub

samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Removed this test altogether since we check vstorage in the advancement test too now

View on GitHub

samsiegart created a review on a pull request on Agoric/agoric-sdk

View on GitHub

samsiegart pushed 1 commit to srs-advance-test Agoric/agoric-sdk
  • fixup! test(fast-usdc): bootstrap test for advancement 9a56730

View on GitHub

samsiegart opened a pull request on Agoric/agoric-sdk
test(fast-usdc): bootstrap test for advancement
refs https://github.com/Agoric/agoric-sdk/issues/10511
samsiegart pushed 1 commit to srs-advance-test Agoric/agoric-sdk
  • test(fast-usdc): bootstrap test for advancement 76ac3e4

View on GitHub

samsiegart created a branch on Agoric/agoric-sdk

srs-advance-test - monorepo for the Agoric Javascript smart contract platform

samsiegart pushed 21 commits to srs-fee-config Agoric/agoric-sdk
  • fix(orchestration): harden result of reverseConnInfo non-hardened objects can't go in stores such as `connectionInfos`. 5c1219c
  • chore(orchestration): log keys of registered chains, assets, ... c5521e5
  • chore(fast-usdc): chainInfo, assetinfo in test/supports privateArgs - realistic USDC denom in test supports 8cb5018
  • style: lint / organize imports in settler.test 3807763
  • chore: settler: log on rejection 61067a7
  • chore: parameterize settler LogFn 661b05b
  • chore: sync notifyAdvancingResult interface guard c4546a2
  • chore: report fullAmount from settler to advanceOutcome 3f0036b
  • chore: provide fullAmount from advancer to settler.notify... 32d362b
  • test: advancer: use fullAmount / advanceAmount (WIP) 3f5210d
  • chore: real sourceChannel for settler d9a9791
  • test(fast-usdc): contract flow tests 10 tests passed 1 known failure 2 tests skipped 7 tests todo Done in 3.4... 4652d32
  • chore: update snapshots for chainInfo 49bd809
  • chore: settler: don't forward without evidence dcc6feb
  • test: fast-usdc contract flow (#10572) refs: #10388 closes: #10577 doesn't close until - exercise all the code in ... 45d0417
  • feat(fast-usdc): publish feeConfig to vstorage 08b2e13
  • feat: showValue option for documentStorageSchema 07d12d4
  • chore: show parsed feedPolicy in storage snapshot 4dc9720
  • chore: regen snapshots with parsed feedPolicy etc. c252da2
  • chore(boot): show parsed agoricNames chain info 237994e
  • and 1 more ...

View on GitHub

samsiegart created a review on a pull request on Agoric/agoric-sdk

View on GitHub

samsiegart opened a pull request on Agoric/agoric-sdk
feat(fast-usdc): publish feeConfig to vstorage
closes: https://github.com/Agoric/agoric-sdk/issues/10509 I accidentally closed https://github.com/Agoric/agoric-sdk/pull/10583 when squashing the merge commits, making a new PR
samsiegart created a branch on Agoric/agoric-sdk

srs-fee-config - monorepo for the Agoric Javascript smart contract platform

samsiegart closed a pull request on Agoric/agoric-sdk
feat(fast-usdc): publish feeConfig to vstorage
closes: https://github.com/Agoric/agoric-sdk/issues/10509 ## Description Publish the feeConfig to vstorage in the fastUSDC contract start function
samsiegart deleted a branch Agoric/agoric-sdk

srs-fee-config

Load more