Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
No objections to this personally
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Just wondering, where do all these accounts come from? I'm guessing we have the private keys somewhere so that a script can use them? I recognize gov1 and gov2 from emerynet at least...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
I guess this doesn't run until @agoric/synthetic-chain spins up the chain and stuff?
samsiegart created a review on a pull request on Agoric/agoric-sdk
LGTM but will defer approval to others, I don't think I know enough about a3p to validate
samsiegart created a review on a pull request on Agoric/agoric-sdk
LGTM but will defer approval to others, I don't think I know enough about a3p to validate
samsiegart created a review on a pull request on Agoric/agoric-sdk
I'm confused, because when I pull this branch locally and run `yarn test` I see: ``` Uncaught exception in test/cli/cli.test.ts TypeError: Cannot assign to read only property 'constructor' o...
samsiegart created a review on a pull request on Agoric/agoric-sdk
Hmm, I just ran `yarn` at the top level of the sdk (rather than just in `packages/fast-usdc`), and it works now. I see we have a patch for axios, and it wasn't being applied without that. I just co...
samsiegart created a review on a pull request on Agoric/agoric-sdk
I'm confused, because when I pull this branch locally and run `yarn test` I see: ``` Uncaught exception in test/cli/cli.test.ts TypeError: Cannot assign to read only property 'constructor' o...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
Not really my preference, though I see where you're coming from.
samsiegart created a comment on a pull request on Agoric/agoric-sdk
>All these tests make me curios... do we have code coverage numbers? Were you aiming for complete coverage or something? We do have codecov if you look in the workflows: https://github.com/Agori...
samsiegart opened a pull request on Agoric/agoric-sdk
feat(fast-usdc): add cli config and args for deposit and withdraw
refs https://github.com/Agoric/agoric-sdk/issues/10328
samsiegart pushed 1 commit to srs-fusdc-cli Agoric/agoric-sdk
- feat(fast-usdc): add cli config and args for deposit and withdraw 47729e8
samsiegart created a branch on Agoric/agoric-sdk
srs-fusdc-cli - monorepo for the Agoric Javascript smart contract platform
samsiegart created a branch on Agoric/agoric-sdk
srs-fix-regex - monorepo for the Agoric Javascript smart contract platform
samsiegart pushed 14 commits to srs-fu-cli Agoric/agoric-sdk
- fix(ertp): remove unneeded ertp type imports (#10467) closes: #XXXX refs: #XXXX ## Description For some reason, vs... e96ff82
- chore(agoric-cli): Document external consumption of gettingStartedWorkflowTest (#10475) ## Description Without this,... ff8c142
- feat(fast-usdc): stub transfer cli command 1b64d82
- feat(fast-usdc): stub config cli command 81e14b2
- feat(fast-usdc): implement config cli command d121e1d
- feat(fast-usdc): implement transfer cli command 504818f
- refactor(fast-usdc): use file objects rather than paths f0f76db
- test(fast-usdc): test cli transfer cac96bb
- chore(fast-usdc): use import rather than typedef 9b06146
- fix(fast-usdc): use correct address format in cli d225974
- fix(fast-usdc): ensure cli non-zero exit code on failure 6c0e77b
- chore(fast-usdc): docs and hardening 992a56d
- chore(fast-usdc): add type to util fn 52033cf
- fix(fast-usdc): fix url encoding d46cefd
samsiegart pushed 15 commits to srs-fu-cli Agoric/agoric-sdk
- refactor(a3p-integration): Document build-submission.sh w.r.t. package.json "agoricProposal" Also document build-all... 02f371c
- docs(a3p-integration): Better describe core-eval generation c0c5b84
- refactor(a3p-integration): Document and clean up core-eval generation (#10466) ## Description Resolving some confusi... d727cf9
- feat(fast-usdc): stub transfer cli command 1a58a6d
- feat(fast-usdc): stub config cli command ab527d3
- feat(fast-usdc): implement config cli command 285bcbe
- feat(fast-usdc): implement transfer cli command cfc04f1
- refactor(fast-usdc): use file objects rather than paths f64285b
- test(fast-usdc): test cli transfer 8d0dd9a
- chore(fast-usdc): use import rather than typedef 3cf6042
- fix(fast-usdc): use correct address format in cli 036a1bb
- fix(fast-usdc): ensure cli non-zero exit code on failure 9cfd76c
- chore(fast-usdc): docs and hardening 0befb41
- chore(fast-usdc): add type to util fn be67cf1
- fix(fast-usdc): fix url encoding 98d08f3
samsiegart pushed 62 commits to srs-fu-cli Agoric/agoric-sdk
- feat: `TxStatus` const for `StatusManager` states 1376020
- types: `CctpTxEvidence`, `PendingTx` 646df78
- test: `MockCctpTxEvidences` and `MockVTransferEvents` fixtures 5e4139c
- feat: `CctpTxEvidenceShape`, `PendingTxShape` typeGuards 5a7b3d2
- chore: export `denomHash` helper 1063efd
- feat: minimal `addressTools` for query param parsing 6f97e13
- refactor: `getChainInfoByAddress` -> `makeChainAddress` - removes `getChainInfoByAddress` and provides `makeChainAd... 3f71342
- feat: `StatusManager` scaffold - shows the various `StatusManager` MapStore states updates (`OBSERVED`, `ADVANCED`) ... 980463f
- feat: `StatusManager` tracks `seenTxs` - use a composite key of `txHash+chainId` to track unique `EventFeed` submiss... f3d1e36
- feat: fusdc status manager states (#10406) closes: #10389 ## Description - `StatusManager` with `OBSERVED`, `ADVANC... c236c55
- chore(a3p-integration): Clean up tryISTBalances bb8d2cd
- fix(client-utils): Retry at least every other interval ...even when a backing operation hangs (e.g., `follow` of an ... fd9394b
- chore(a3p-integration): Increase the verbosity of psmSwap 2ced1d5
- feat(agoric-cli): Block `agoric wallet send` on tx inclusion 0389a21
- test(a3p-integration): Update "swap into IST" to force the default gas limit 1369e6b
- feat(agoric-cli): Add `agoric wallet send` gas limit options ...defaulting to `--gas=auto --gas-adjustment=1.2`. 21a03f8
- refactor(a3p-integration): Use execa rather than a custom `runCommand` 236a61f
- style(a3p-integration): Use `concat` to group `agd` CLI arguments c98ee13
- style(agoric-cli): Introduce `gas` option helper 4016066
- fix(agoric-cli): Default `agoric wallet send` to use `--gas=auto` (#10447) ## Description Extracted from #10165. Whe... fb76d70
- and 42 more ...
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
I would but then it makes me pull all the args into the docstring as well, quite annoying
samsiegart created a review comment on a pull request on Agoric/agoric-sdk
I had to fix this anyway. It will now encode all of `appendedAddr`, which I think should work regardless.
samsiegart created a comment on a pull request on Agoric/agoric-sdk
Logs from a successful run after updating the URL encoding (ignore the insufficient funds thing, that's just because my eth account was empty): ``` $ fast-usdc transfer 0.25 dydx1234 --home=demo/...
samsiegart pushed 1 commit to srs-fu-cli Agoric/agoric-sdk
- chore(fast-usdc): add type to util fn 2054099