Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pkalita-lbl created a review on a pull request on microbiomedata/docs
Looks pretty good! Just a few minor comments.
pkalita-lbl created a review comment on a pull request on microbiomedata/nmdc-server
I think it would be better to completely swap out what we show in this card based on whether this submission is or is not a test. There is a bit of plumbing needed in order to do that, but I think ...
pkalita-lbl created a review comment on a pull request on microbiomedata/nmdc-server
In order to not have two visually prominent primary buttons next to each other, I'd recommend adding the `outlined` prop here. More details in Slack conversation.
pkalita-lbl created a review on a pull request on microbiomedata/nmdc-server
I tested these changes locally and everything pretty much works as expected. I just have a few small enhancements to consider.
pkalita-lbl created a review on a pull request on microbiomedata/nmdc-server
I tested these changes locally and everything pretty much works as expected. I just have a few small enhancements to consider.
pkalita-lbl pushed 2 commits to issue-132-firebase-analytics microbiomedata/nmdc-field-notes
pkalita-lbl opened a draft pull request on microbiomedata/nmdc-field-notes
Use Firebase for analytics reporting
Fixes #132 ### Summary These changes introduce the Firebase native (iOS and Android) and web SDKs via a [Capacitor plugin](https://capawesome.io/plugins/firebase/analytics/). This allows a n...
pkalita-lbl pushed 2 commits to issue-132-firebase-analytics microbiomedata/nmdc-field-notes
pkalita-lbl pushed 2 commits to issue-132-firebase-analytics microbiomedata/nmdc-field-notes
pkalita-lbl pushed 2 commits to issue-132-firebase-analytics microbiomedata/nmdc-field-notes
pkalita-lbl pushed 1 commit to issue-132-firebase-analytics microbiomedata/nmdc-field-notes
- Update the firebase config used by web versions 3bb9521
pkalita-lbl pushed 2 commits to issue-132-firebase-analytics microbiomedata/nmdc-field-notes
pkalita-lbl pushed 2 commits to issue-132-firebase-analytics microbiomedata/nmdc-field-notes
pkalita-lbl deleted a branch microbiomedata/submission-schema
issue-227-examples-in-schema-validation
pkalita-lbl pushed 29 commits to main microbiomedata/submission-schema
- Add pytest as direct dev dependency 7529128
- Fix understory example in env_local_scale 2334051
- Include unit in built_struc_age example 54e29d7
- Use only range examples for depth in SedimentInterface and SoilInterface cf5a094
- Use GrowthFacilEnum permissible value for growth_facil example 87c5cc5
- Update diether_lipids example to conform to {text};{value} {unit} pattern 7009db9
- Update heavy_metals examples to conform to {text};{value} {unit} pattern fe9ef8b
- Update phaeopigments examples to conform to {text};{value} {unit} pattern 60e13da
- Add organism_count pattern override to all applicable classes ef73c44
- Update al_sat pattern and example to use percentage format e4860ef
- Change occup_samp range to integer f25748d
- Allow microbial_biomass values to have a unit with spaces 47e7dad
- Make phosplipid_fatt_acid a single concentration measurement 100064c
- Update rel_air_humidity to admit plain percentage 462f71a
- Update slope_gradient to admit plain percentage 45d65f2
- Update surf_humidity to admit plain percentage b84447f
- Use StoreCondEnum permissible value for store_cond example 7cb1b1f
- Use SampleTypeEnum permissible value for sample_type example 4fa0532
- Use ShadingDeviceTypeEnum permissible value for shading_device_type example 99a6d57
- Update root_med_carbon, root_med_macronutr, root_med_micronutr examples to match existing pattern 00a71f7
- and 9 more ...
pkalita-lbl closed an issue on microbiomedata/submission-schema
Ensure all values listed in `examples` for a slot actually pass validation
In https://github.com/microbiomedata/nmdc-field-notes/issues/184, it was pointed out that there are a number of values listed as `examples` for some slots which do not conform to the validation rul...
pkalita-lbl closed a pull request on microbiomedata/submission-schema
Ensure all examples in schema validate
Fixes #227 ### Summary These changes ensure that all examples listed in slot definitions are valid according to that slot definition. * In many cases this is simply a matter of modifying...
pkalita-lbl pushed 2 commits to main geneontology/gocam-py
pkalita-lbl pushed 2 commits to main linkml/linkml
pkalita-lbl closed a pull request on linkml/linkml
[poetry] Update Lockfile
Update poetry dependencies: | Current | Updated | | ------- | ------- |
pkalita-lbl created a review comment on a pull request on microbiomedata/nmdc-runtime
You might have already explained this to me and I've forgotten, but why do we keep this file in the `nmdc-schema` repository?
pkalita-lbl created a review comment on a pull request on microbiomedata/nmdc-runtime
Similar to the above comment, I'm a little hesitant about the "missing" part of this name. To me this is `generate_data_generation_set_from_gold_api`.
pkalita-lbl created a review comment on a pull request on microbiomedata/nmdc-runtime
I think this needs a more specific name since it produces a very specific file name.
pkalita-lbl created a review comment on a pull request on microbiomedata/nmdc-runtime
Is there any value in this being a class? Since it's not inheriting from anything and the internal state never really gets modified, could `create_missing_dg_records` just be a top-level function i...
pkalita-lbl created a review comment on a pull request on microbiomedata/nmdc-runtime
To me "fill" implies that it's going to actually commit the results to Mongo. Is there any reason this Graph doesn't do that?
pkalita-lbl created a review on a pull request on microbiomedata/nmdc-runtime
Overall this looks nice and I appreciate the documentation you've added. I have some comments and questions, but none of it is so critical that it needs to hold up merging. --- I guess my mai...
pkalita-lbl created a review on a pull request on microbiomedata/nmdc-runtime
Overall this looks nice and I appreciate the documentation you've added. I have some comments and questions, but none of it is so critical that it needs to hold up merging. --- I guess my mai...
pkalita-lbl closed a pull request on linkml/linkml-project-cookiecutter
Update to Poetry 2.0
I have tested Poetry-2.0 in our repo here https://github.com/nfdi4cat/pid4cat-model/pull/36. This PR switches as much as possible to the PEP 621 standard. The few remaining `[tool.poetry....]` sect...