Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion req_url = "{}{}".format(consts.MSGENTRA_LOGIN_BASE_URL, consts.MSGENTRA_SERVER_TOKEN_URL.format(tenant_id=quote(self._tenant))) ret_val, resp_json = self._make_res...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion if not (self._certificate_thumbprint and self._certificate_private_key): self.save_progress(consts.MSGENTRA_CBA_AUTH_ERROR) return self.set_status(p...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion headers.update({"User-Agent": consts.MSGENTRA_USER_AGENT.format(product_version=self.get_app_json().get("app_version"))}) ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion return action_result.set_status(phantom.APP_ERROR, consts.MSGENTRA_CBA_KEY_ERROR), None ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion url = f"{consts.MSGENTRA_SOAR_BASE_URL.format(soar_base_url=self.get_phantom_base_url())}{consts.MSGENTRA_SOAR_SYS_INFO_URL} ret_val, resp_json = self._make_rest_cal...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion rest_endpoint = consts.MSGENTRA_SOAR_ASSET_INFO_URL.format(asset_id=asset_id) url = f"{consts.MSGENTRA_SOAR_BASE_URL.format(soar_base_url=self.get_phantom_base_url()...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion if consts.MSGENTRA_TOKEN_EXPIRED in action_result.get_message(): ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion "User-Agent": consts.MSGENTRA_USER_AGENT.format(product_version=self.get_app_json().get("app_version")), ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion if not self._non_interactive: token_data = { "client_id": self._client_id, "grant_type": consts.MSGENTRA_REFRESH_TOKEN_STRING, ...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion return action_result.set_status(phantom.APP_ERROR, status_message=consts.MSGENTRA_TOKEN_NOT_AVAILABLE_MSG), None ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion error_msg = consts.MSGENTRA_ERROR_MSG_UNAVAILABLE ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion def _validate_integer(self, action_result, parameter, key, allow_zero=True): if parameter is not None: try: if not float(parameter).is_inte...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion state[consts.MSGENTRA_CODE_STRING] = code state[consts.MSGENTRA_STATE_IS_ENCRYPTED] = True except Exception as e: return HttpResponse(f"{consts.MSGENTR...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion message = "Error from server. Status Code: {0} Error Code: {1} Data from server: {2}".format( response.status_code, resp_json.get("error", {}).ge...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion if isinstance(resp_json.get("error"), dict) and resp_json.get("error", {}).get(consts.MSGENTRA_CODE_STRING): ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion state = self.check_state_fields(state, encryption_helper.encrypt, consts.MSGENTRA_ENCRYPTION_ERROR) ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion return self.check_state_fields(state, encryption_helper.decrypt, consts.MSGENTRA_DECRYPTION_ERROR) ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Nit: this is py2-ism ```suggestion super().__init__() ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion code = request.GET.get(consts.MSGENTRA_CODE_STRING) ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
I actually _hate_ this recommendation from our own app wizard and standards, and I will be eradicating it ASAP. Wildcard imports are a terrible idea ```suggestion import msgraphforentra_consts as...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion auth_status_file_path = "{0}/{1}_{2}".format(app_dir, asset_id, consts.MSGENTRA_TC_FILE) ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
This is a py2/py3 compat layer thing which is not necessary ```suggestion from urllib.parse import quote, urlencode ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion # Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
These functions are all doing the same thing, this is a great opportunity to dedupe code: ```suggestion def add_results_to_context(all_app_runs, context): context["results"] = results = []...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion # Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Can we list the supported actions here?