Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion auth_status_file_path = "{0}/{1}_{2}".format(app_dir, asset_id, consts.MSGENTRA_TC_FILE) ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
This is a py2/py3 compat layer thing which is not necessary ```suggestion from urllib.parse import quote, urlencode ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion # Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
These functions are all doing the same thing, this is a great opportunity to dedupe code: ```suggestion def add_results_to_context(all_app_runs, context): context["results"] = results = []...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion # Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Can we list the supported actions here?
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion # Copyright (c) 2022-2025 Splunk Inc. ```
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Please remove this requirement. We need better documentation and long-term plans around this, but certain dependencies we're just allowing the platform to provide at the moment, due to an insurmoun...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Action name is `list signins` but table is `List Incidents`?
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Pretty sure static tests will get mad at this (I know, I think it's silly too) ```suggestion "filter": { "description": "Filter risk detections based on prope...
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Do we not have a boolean data type?
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
boolean?
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
If the action name is `list devices`, why is the table title `List Incidents`?
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Is Entra a Defender add-on or is this bad copypasta?
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Missing datapaths
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Why do we have a bunch of ignored parameters? Is this my inexperience with connector development showing, and `on poll` just requires these parameters by some esoteric design?
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
Missing the standard data paths here
phantom-jacob created a review comment on a pull request on splunk-soar-connectors/msgraphforentra
```suggestion checkbox is toggled then the test connectivity action must be run again. NOTE: Non-Interactive Auth must be checked for Certificate Based Authentication. ```
phantom-jacob pushed 8 commits to main splunk-soar-connectors/runnerutility
- Rename 1.0.17 to 1.0.17.md fixed file name 3177ab4
- Merge pull request #1 from zamastyle/zamastyle-patch-1 Rename 1.0.17 to 1.0.17.md 182bcf6
- Merge branch 'splunk-soar-connectors:next' into Fix-notes 0e78e69
- Merge pull request #13 from zamastyle/Fix-notes Fix notes 29fc511
- Bumped up the version of runnerutility from 1.0.17 to 1.0.18 789f656
- Release notes for version 1.0.18 969456c
- Release notes for version 1.0.18 97cbd3a
- Merge pull request #14 from splunk-soar-connectors/next Merging next to main for release 1.0.18 22899f5
phantom-jacob closed a pull request on splunk-soar-connectors/runnerutility
Merging next to main for release 1.0.18
### Notes - Merging next to main for the latest release - Please review the app version, generated release notes and readme, and make any necessary updates ### Requirements * [ ] Merge all associa...
phantom-jacob pushed 11 commits to main splunk-soar-connectors/freshservice
- Freshservice: New app - Initial commit 0c98d69
- Freshservice: New app - Initial commit 26ad30f
- Fixed linting error and Developer checklist changes 91340d8
- Added log statements 5e3d8fa
- Merge pull request #1 from dan3hr/your-branch Freshservice: New app - Initial commit 1992c07
- Release notes for version 1.1.0 dc2515b
- fix(pre-commit): Updated pre-commit and linted/formatted a274b01
- Update README.md 73cc40d
- Merge pull request #3 from splunk-soar-connectors/jacobd-lint fix(lint): Fixing static test failures in preparation ... bf9c6cc
- Release notes for version 1.1.1 1e56bb7
- Merge pull request #2 from splunk-soar-connectors/next Merging next to main for release 1.1.1 963d750
phantom-jacob closed a pull request on splunk-soar-connectors/freshservice
Merging next to main for release 1.1.1
### Notes - Merging next to main for the latest release - Please review the app version, generated release notes and readme, and make any necessary updates ### Requirements * [ ] Merge all associa...
phantom-jacob pushed 3 commits to next splunk-soar-connectors/freshservice