Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

pbartholomew08

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
ABL -> Cavity, it appears all CMakeLists.txt have "ABL" as their comment

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Is this intentional?

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Why leave out the wind turbine examples?

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Is this intentional?

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Is this intentional?

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Is this intentional?

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Is this intentional?

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Does the `data` subdirectory not help keep this tidy?

View on GitHub

pbartholomew08 created a review on a pull request on xcompact3d/Incompact3d
A few minor things, but looks good!

View on GitHub

pbartholomew08 created a review on a pull request on xcompact3d/Incompact3d
A few minor things, but looks good!

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Or perhaps the trilinear interpolation function can do the error checking?

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
I think you can write a single/generic version of this using `class(*)` as the type of `var`.

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
I think you can write a single/generic version of this using `class(*)` as the type of `var`

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
replace `1.d-16` with `epsilon(1.0_mytype)`. I would add this to the local data of subroutine, e.g. ``` real(mytype), parameter :: eps = epsilon(1.0_mytyp) ``` or you could make this a module v...

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
use `1.0_mytype`

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
I don't understand what you mean by this comment

View on GitHub

pbartholomew08 pushed 1 commit to 44-poisson-solver-iterative-solver pbartholomew08/x3d2
  • Generalise the Poisson evaluation test to work with generic linear operators 824c631

View on GitHub

pbartholomew08 pushed 1 commit to develop CFLaboratory/CFGrid
  • chore: Update .clang-format indentation style 0ec7b7d

View on GitHub

pbartholomew08 pushed 2 commits to tidy-reader CFLaboratory/CFGrid
  • docs: Add documentation of the gmsh_header struct e3509db
  • docs: Add documentation for the gmsh_header_parser class d040bd4

View on GitHub

pbartholomew08 created a review comment on a pull request on CFLaboratory/CFGrid
Done

View on GitHub

pbartholomew08 created a review on a pull request on CFLaboratory/CFGrid

View on GitHub

pbartholomew08 created a review comment on a pull request on CFLaboratory/CFGrid
Done

View on GitHub

pbartholomew08 created a review on a pull request on CFLaboratory/CFGrid

View on GitHub

pbartholomew08 pushed 2 commits to tidy-reader CFLaboratory/CFGrid
  • docs: Add documentation of the gmsh_header struct e6cd456
  • docs: Add documentation for the gmsh_header_parser class 16143b8

View on GitHub

pbartholomew08 pushed 8 commits to tidy-reader CFLaboratory/CFGrid
  • chore: Update Copyright and add funding acknowledgment ea6f361
  • refactor: Tidy up the get_format utility function 98cfd62
  • refactor: Encapsulate get_format functionality into classes 9b38d17
  • refactor: Lift gmsh_header_parser implementation into source file 27cb108
  • tests: Add testing for the gmsh_header_parser 9cff84f
  • refactor: Remove unused include a51271b
  • refactor: Add nodiscard attribute on function return values 2fc3ea7
  • refactor: Add const property on lambda return values 69d0ab3

View on GitHub

pbartholomew08 pushed 1 commit to develop CFLaboratory/CFGrid
  • chore: Update Copyright and add funding acknowledgment ea6f361

View on GitHub

pbartholomew08 created a review comment on a pull request on CFLaboratory/CFGrid
Done

View on GitHub

pbartholomew08 created a review on a pull request on CFLaboratory/CFGrid

View on GitHub

pbartholomew08 pushed 2 commits to tidy-reader CFLaboratory/CFGrid
  • refactor: Add nodiscard attribute on function return values e87a03e
  • refactor: Add const property on lambda return values d104672

View on GitHub

pbartholomew08 created a review comment on a pull request on CFLaboratory/CFGrid
Add `[[nodiscard]]`

View on GitHub

Load more