Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
oliasymak24 created a review on a pull request on mate-academy/py-herbivores-and-carnivores
Good job!
oliasymak24 created a review comment on a pull request on mate-academy/py-herbivores-and-carnivores
Each parameter must be from new line
oliasymak24 created a review comment on a pull request on mate-academy/py-cinema-visit
Each parameter must be from new line
oliasymak24 created a review comment on a pull request on mate-academy/py-software-engineers
No need to rewrite init method here
oliasymak24 created a review comment on a pull request on mate-academy/py-person-class
Use just dict.get() method in the condition, instead of this long one, check everywhere
oliasymak24 created a review comment on a pull request on mate-academy/py-person-class
don't leave comments
oliasymak24 created a review comment on a pull request on mate-academy/py-person-class
Try to rewrite in one line. Hint: list comprehension
oliasymak24 created a review comment on a pull request on mate-academy/py-person-class
This is bad we are using only english in the code
oliasymak24 created a review comment on a pull request on mate-academy/py-distance-class
You don't need this check here, your function anyway takes only int and float types, according to your type annotations
oliasymak24 created a review comment on a pull request on mate-academy/py-distance-class
Please check your checklist after the task)
oliasymak24 created a review comment on a pull request on mate-academy/py-distance-class
What if `other` is of type `Distance` here and in all the following methods?
oliasymak24 created a review comment on a pull request on mate-academy/py-distance-class
try to rewrite this method in one line. Use previously created magic methods Hint: <= is the same as `not >
oliasymak24 created a review comment on a pull request on mate-academy/py-distance-class
try to rewrite this method in one line each. Use previously created magic methods Hint: `<=` is the same as `not >
oliasymak24 created a review comment on a pull request on mate-academy/py-distance-class
What if number not int nor float?
oliasymak24 created a review comment on a pull request on mate-academy/py-distance-class
Use double quotes
oliasymak24 created a review comment on a pull request on mate-academy/py-cache-decorator
This is not correct, called prematurely
oliasymak24 created a review comment on a pull request on mate-academy/py-cache-decorator
Always add a blank line at the end of the file.
oliasymak24 created a review comment on a pull request on mate-academy/py-cache-decorator
Always add a blank line at the end of the file.