Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
and here
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
Same here
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
Must be separated into basic absract class and two children, use Single Responsibility Principle
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
You need to split into different files
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
Put return just here or even just print, then you don't need to call print when you call main
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
This is renudant
oliasymak24 created a review on a pull request on mate-academy/py-solid-book-service-refactoring
Good job!
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
The same here, Dispaley must be an absrtact class with children
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
Serialize must be a parent abstaract class and must have two children
oliasymak24 created a review on a pull request on mate-academy/py-solid-book-service-refactoring
No need to create folders and new file for each class, you need to use Interface Segregation Principle and abstarct classes, for example for displays, you need one file with parent abstract class a...
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
And here
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
Same here
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
Why you nedd class where you create staticmethod? Create abstarct class here and then 2 children
oliasymak24 created a review comment on a pull request on mate-academy/py-solid-book-service-refactoring
Move into separate file these classes
oliasymak24 created a review on a pull request on mate-academy/py-solid-book-service-refactoring
Good job!
oliasymak24 created a review on a pull request on mate-academy/py-solid-book-service-refactoring
Good job!
oliasymak24 created a review comment on a pull request on mate-academy/py-asyncio-iot
Use triple quotes in such cases
oliasymak24 created a review comment on a pull request on mate-academy/py-asyncio-iot
Delete unnecessary comments
oliasymak24 created a review comment on a pull request on mate-academy/py-asyncio-iot
Add annotation, must be consistent
oliasymak24 created a review on a pull request on mate-academy/py-asyncio-iot
Minor comment, but still need to fix)