Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mvaivre created a review comment on a pull request on alephium/alephium-frontend
Also, nit rename : `useClearPersistedQueryCacheOnVersionUpdate()`. If we say that it's "persisted", we don't need to say that it's a "cache". WDYT?
mvaivre created a review comment on a pull request on alephium/alephium-frontend
I understand why you created a component instead of a hook for this (to avoid running anything if it's not needed), but this highlights when of the limitation of React that is a bit frustrating to ...
mvaivre created a review comment on a pull request on alephium/alephium-frontend
Nit: I would always specify that we're talking about the `PersistedQueryCache`, like you did in the related hooks and other functions. We may persist other caches in the future.
mvaivre created a review comment on a pull request on alephium/alephium-frontend
Is there a reason why this is not extracted out of `App.tsx` like the other hooks?
mvaivre created a review on a pull request on alephium/alephium-frontend
Code looks good to me. Only nit comments so I approve! Let's make an rc, test like crazy (the whole testing suite, I'll go through it thoroughly on Monday morning), and release 🚀
mvaivre created a review on a pull request on alephium/alephium-frontend
Code looks good to me. Only nit comments so I approve! Let's make an rc, test like crazy (the whole testing suite, I'll go through it thoroughly on Monday morning), and release 🚀
mvaivre opened an issue on alephium/alephium-frontend
Addresses aren't shown after an import
Restarting the wallet "fixes" it
mvaivre pushed 1 commit to update-milestones alephium/www
- Fix gradient, show description of tasks on hover dc5e351
mvaivre pushed 11 commits to update-milestones alephium/www
- Create Banxa callback page 0a82568
- Fix alignment of 404 page c81c5d5
- Ignore link checker false negatives 9c94c69
- Fix iframes CSP c3b5bc1
- Merge pull request #173 from alephium/fix-csp Fix iframes CSP 94187c7
- Add banxa callback page in robots.txt b554f0e
- Merge pull request #172 from alephium/banxa-callback Create Banxa callback page and fix 404 page 4e8b8e6
- Add terms and conditions page 49282db
- Merge pull request #175 from alephium/add-t-and-c Add terms and conditions page 53fb08f
- Update milestones 381faf7
- TODO list redesign 5919d70
mvaivre closed an issue on alephium/www
Add Terms of Use
https://docs.google.com/document/d/169mbWASQx9Ns2gy71U7-fpiYmhqQZzP5/edit Add the Terms of use to the website. Adding a “Terms of Use” link to the footer seems like the most straightforward...
mvaivre pushed 2 commits to master alephium/www
mvaivre created a review on a pull request on alephium/alephium-frontend
CMOOOOOOOOOONNNNNNNNNNNNNNNNNNNNNNNNNNNN
mvaivre created a review comment on a pull request on alephium/alephium-frontend
That's weird, there are multiple new lines EOF across the PR, but I guess we don't care :)
mvaivre pushed 1 commit to UI-redesign-part4 alephium/alephium-frontend
- Fixes in new contact modal / screen c1d81bb
mvaivre pushed 1 commit to UI-redesign-part4 alephium/alephium-frontend
- Improve Transaction modal b790895
mvaivre pushed 1 commit to UI-redesign-part4 alephium/alephium-frontend
- Dynamically mount modal's children according to their "scrollability" 7fdfa69
mvaivre pushed 1 commit to UI-redesign-part4 alephium/alephium-frontend
- DRY things up with BottomModalBase 690aa7b
mvaivre pushed 1 commit to UI-redesign-part4 alephium/alephium-frontend
- Fix bottom modal scroll (Android) + avoid clash on iOS However, scroll down to close modal is not working on Android d0f26b0