Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mellyeliu pushed 1 commit to main facebook/stylex
- fix valid-shorthands null object error from null css-shorthand-expand return (#814) db00997
mellyeliu closed a pull request on facebook/stylex
fix: fix valid-shorthands object casting error on css-shorthand-expand null return
## What changed / motivation ? Certain complex shorthand values like `'4px solid var(--fds-gray-10)'` seem to trip up the css-shorthand-expand package, which defaults to returning null. Let's ha...
mellyeliu created a review comment on a pull request on facebook/stylex
still identifying repros to make the test more robust
mellyeliu pushed 1 commit to cli-cache facebook/stylex
- fix valid-shorthands null object error from null css-shorthand-expand return f6c51f8
mellyeliu opened a draft pull request on facebook/stylex
fix: fix valid-shorthands object casting error on css-shorthand-expand null return
## What changed / motivation ? Certain complex shorthand values like `'4px solid var(--fds-gray-10)'` seem to trip up the css-shorthand-expand package, which defaults to returning null. Let's ha...
mellyeliu pushed 1 commit to cli-cache facebook/stylex
- Merge branch 'main' of github.com:facebook/stylex into cli-cache dd32a5c
mellyeliu created a comment on a pull request on facebook/stylex
updated to prefix the _variable names_ with key as discussed with @nmn
mellyeliu created a review comment on a pull request on facebook/stylex
good callout! will address this in a follow up as it seems to be the default pattern across all the tests in the test suite
mellyeliu pushed 1 commit to cli-cache facebook/stylex
- Merge branch 'main' of github.com:facebook/stylex into cli-cache d9a7d30
mellyeliu pushed 6 commits to cli-cache facebook/stylex
- chore: make cli testing async (#804) 92f98e7
- feat: add autofix for logical to inline properties in valid-styles rule (#805) f9ec2b4
- chore: fix @property inherits syntax (#806) 95feb9f
- feat: add dynamic styles to benchmarks fixture (#807) * feat: add dynamic styles to benchmarks fixture * fix styl... 848bd85
- update read values and modify prepending to var name e98d508
- Merge branch 'main' of github.com:facebook/stylex into cli-cache e0125d2
mellyeliu pushed 1 commit to main facebook/stylex
- feat: add autofix for logical to inline properties in valid-styles rule (#805) f9ec2b4
mellyeliu closed a pull request on facebook/stylex
feat: add autofix for logical to inline properties in valid-styles rule
## Context As per internal discussions, let's add an autofix into the valid-styles rule. Some of this logic exists in the valid-shorthands rule, but it makes sense to move the erroring here for ...
mellyeliu created a comment on a pull request on facebook/stylex
> LGTM (once message bikeshedding is complete) I had to google this #til Parkinson's Law of Triviality
mellyeliu pushed 1 commit to valid-styles-fix facebook/stylex
- address comments to highlight nonstandard css df8c7a3
mellyeliu opened a pull request on facebook/stylex
feat: add autofix to inline properties in valid-styles rule
## Context As per internal discussions, let's add an autofix into the valid-styles rule. Some of this logic exists in the valid-shorthands rule, but it makes sense to move the erroring here for ...
mellyeliu created a branch on facebook/stylex
valid-styles-fix - StyleX is the styling system for ambitious user interfaces.
mellyeliu closed a pull request on facebook/stylex
chore: refactor cli cache tests to be async
## Context Follow up to https://github.com/facebook/stylex/pull/790 and https://github.com/facebook/stylex/pull/792 Let's clean up the tests and move to async functions ## Pre-flight chec...
mellyeliu created a review comment on a pull request on facebook/stylex
current type definitions are outdated so flow is erroring on this, will keep for now