Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mathrack pushed 1 commit to UpdateTests xcompact3d/Incompact3d
- Fix typo in X3D_CREATE_TEST.cmake b05adc2
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
I think the new version is better, no need to fix in my opinion
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
As a side remark, MPI_Wtime is returning a double precision number. If accuracy is needed on the timer, the single precision builds should not store the result in a variable defined with `real(myty...
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
The other modifications are looking equivalent to the current code. This is probably the only one changing the behavior.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
This modification is fixing a minor issue ? The code was printing the local value before. Now it is printing the global value obtained after reduction.
mathrack closed an issue on 2decomp-fft/2decomp-fft
[main] - Issue when writing a 3D array in y/z pencil with reduced precision using mpiio_write_real_coarse
The allocate statement is valid only when the input is in x pencil. It is not valid if the input is in y or z pencil https://github.com/2decomp-fft/2decomp-fft/blob/4ff8f79098e6028dad6efd9d994b6...
mathrack closed an issue on xcompact3d/Incompact3d
IBM - Undefined values in ypraf in case of periodicity
The size of the array `ypraf` is `nyraf = nym nraf`. In case of periodicity, `nym=ny`. Otherwise `nym=ny-1`. The loop used to define `ypraf` will populate the array from `1` to `(ny-1) nraf`. ...
mathrack closed a pull request on xcompact3d/Incompact3d
Move stretching subroutines to a dedicated module and fix undefined ypraf values
…praf values Closing #293
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
As a side remark, I think it is safe to have local 1D arrays (without allocate / deallocate statements). I think the new intel compiler had issues with local 3D arrays. I am not sure what is the si...
mathrack created a comment on a pull request on xcompact3d/Incompact3d
The scope of the present PR is only to fix the issue linked. In my opinion, it would be best to keep deeper code refactoring / modification for another PR :-)
mathrack pushed 1 commit to fix_ypraf_ibm xcompact3d/Incompact3d
- Add the save attribute to the variables in the stretching module 5fd9d63
mathrack created a comment on a pull request on xcompact3d/Incompact3d
I think we could also move the inversion5 subroutines inside this new module. However, this is slightly out of the scope, it is probably best to keep the present PR small.
mathrack pushed 1 commit to fix_ypraf_ibm xcompact3d/Incompact3d
- Move variables alpha and beta to the stretching module c62a303