Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please look at the input and output of the function `psum_integer` and `prelay`. Please describe the difference between both. It seems they are doing providing the exact same output.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
I think there is no need for two functions doing the same job
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please add a statement when you resolve a conversation without any modification in the code
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Without the optional parameter was also possible using `result(output)` and real(mytype) :: output(size(var))
mathrack created a comment on a pull request on xcompact3d/Incompact3d
There are plenty of unresolved comments, I think there is no need for a new review right now
mathrack created a review on a pull request on xcompact3d/Incompact3d
I have suggested some modifications. I have not yet looked at `particle.f90`. I have an error with the following build command : ``` rm -rf ./build/ && FC=mpif90 cmake -S ./ -B ./build -DBUILD_T...
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please add a comment describing the objective of the function and the limitations (`yy1` and `yy2` must be 3D arrays with the same size)
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
I think the variable `var1` is not really needed
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Replace `1e-16_mytype` with `epsilon(xx)` ?
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
This is looking like a duplicate of `psum`
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please add a comment explaining why the printed data size is limited to the second dimension of the array
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
The code below is duplicated. Please refactor or use a dedicated subroutine.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
The code below is duplicated. Please refactor or use a dedicated subroutine.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Are we sure this statement based on the value of `mytype` is portable ?
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
The temporary variable `vta` seems useless. Is ti possible to use directly `table` ?
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Return statement is not needed at the end of a function / subroutine
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Unused variable `nvar` currently.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please make the size of the output explicit so that it is easier to read / understand the function
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please make the size of the output explicit so that it is easier to read / understand the function
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please use similar names, the current naming convention is not looking consistent compared with the other interfaces.
mathrack created a review on a pull request on xcompact3d/Incompact3d
I have suggested some modifications. I have not yet looked at `particle.f90`. I can not test the code. I am using the following build command : ``` rm -rf ./build/ && FC=mpif90 cmake -S ./ -B ./...
mathrack created a review on a pull request on xcompact3d/Incompact3d
I have suggested some modifications. I have not yet looked at `particle.f90`. I can not test the code. I am using the following build command : ``` rm -rf ./build/ && FC=mpif90 cmake -S ./ -B ./...
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Any update on this topic ?
mathrack created a review on a pull request on xcompact3d/Incompact3d
The comments in the previous review needs to be addressed : 1. Make sure the particles can run in single precision 2. Use the halo subroutines available in 2decomp. If it is not possible, plea...
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
This subroutine is doing nothing