Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/react_static-list-of-posts-js
Ensure that the `PostList` component is designed to handle the `posts` prop correctly, especially if it expects a certain structure or non-empty array.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/react_static-list-of-posts-js
The `find` method will return `undefined` if no user is found. The `|| null` part is unnecessary and will not work as intended. Instead, you should handle the case where `find` returns `undefined` ...
mateacademy-ai-mentor created a review on a pull request on mate-academy/react_static-list-of-posts-js
**** Great job on your implementation! 🎉 Your code meets the task requirements and constraints effectively. The components are well-structured, and you've handled the key usage in iterations corre...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The class name `Mashine` is likely a typo. It should be `Machine` according to the task description. Please correct this to ensure consistency and functionality.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The message in `doWork()` is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The message in `stopWork()` is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The class name `Mashine` is likely a typo. It should be `Machine` according to the task description. Please correct this to ensure consistency and functionality.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The class name `Mashine` is likely a typo. It should be `Machine` according to the task description. Please correct this to ensure consistency and functionality.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The loop variable type `Mashine` is likely a typo. It should be `Machine` to match the corrected class name.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The array type `Mashine` is likely a typo. It should be `Machine` to match the corrected class name.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The message in `stopWork()` is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The message in `doWork()` is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The message in `stopWork()` is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The message in `doWork()` is not in English. The task checklist requires all messages to be in English. Please update this message to be informative and in English.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-oop
The class name `Mashine` is likely a typo. It should be `Machine` according to the task description. Please correct this to ensure consistency and functionality.
mateacademy-ai-mentor created a review on a pull request on mate-academy/jv-oop
Thank you for your submission! 🎉 While your code has been approved to help you move forward with your learning journey, there are a few critical issues that need attention: 1. **Class Naming Consi...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/layout_stars
The task requires using container modifiers and pseudo-selectors for yellow stars instead of extra classes. Ensure that your CSS reflects this requirement by using pseudo-selectors like `:nth-child...
mateacademy-ai-mentor created a review on a pull request on mate-academy/layout_stars
Great job on your submission! 🎉 You've made significant progress in aligning your code with the task requirements. Here are a few points to consider for further improvement: 1. **BEM Structure and...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-car-wash-station
The `rate_service` method should update both `average_rating` and `count_of_ratings` based on the new rating provided. According to the task description, you need to adjust the `average_rating` by ...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-car-wash-station
There is a typo in the attribute name `comform_class`. It should be `comfort_class` to match the constructor parameter and the task description.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-car-wash-station
Hello! 😊 You've done a great job so far, but there are a couple of critical issues that need to be addressed before we can approve the Pull Request. 1. **Typographical Error**: There's a typo in ...
mateacademy-ai-mentor created a review on a pull request on mate-academy/layout_stars
Your solution is almost there, but there are a few important issues to address before we can approve it. 🚀 1. **Use of Extra Classes**: The task requires using container modifiers and pseudo-selec...
mateacademy-ai-mentor created a review on a pull request on mate-academy/js_herbivores_and_carnivores
### Review Summary 🎉 Great job on your implementation of the `Animal`, `Herbivore`, and `Carnivore` classes! Your code meets the task requirements and constraints as specified. Here are some highl...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-registration-validation
The condition `user.getAge() == null` should be checked separately from `user.getAge() < MIN_USER_AGE` to enhance readability and align with best practices. This will make the code cleaner and easi...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-registration-validation
The test method `register_shortLogin_notOk` is incorrectly named, as it tests a short login instead of a short password. Please rename it to `register_shortPassword_notOk` to accurately reflect the...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/jv-registration-validation
Consider moving the hardcoded values for minimum login length, minimum password length, and minimum age to constant fields. This change will improve the maintainability and clarity of your code.
mateacademy-ai-mentor created a review on a pull request on mate-academy/jv-registration-validation
**** Great job on implementing the `InvalidUserException` and covering a wide range of test scenarios in your `RegistrationServiceTest` class! 🎉 Your code generally meets the task requirements, bu...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/js_herbivores_and_carnivores
The `die` method is called immediately after reducing the `target`'s health by 50. This means the `Herbivore` will be removed from the `Animal.alive` array regardless of its remaining health. Consi...
mateacademy-ai-mentor created a review on a pull request on mate-academy/js_herbivores_and_carnivores
**** Thank you for your hard work on this pull request! 🌟 Your implementation of the `Animal`, `Herbivore`, and `Carnivore` classes is mostly correct, and you've done a great job meeting the task ...
mateacademy-ai-mentor created a review on a pull request on mate-academy/layout_moyo-header
Great job on your implementation! 🎉 Your code meets the task requirements and constraints effectively. The HTML and CSS files are well-structured and utilize modern practices. The only minor issue ...