Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
loic-sharma created a review comment on a pull request on flutter/flutter
Ultra pendantic nit: errors in Dart are unrecoverable exceptions that shouldn't be caught (see [this doc](https://dart.dev/language/error-handling)). I'd consider renaming this to `socketExceptionO...
loic-sharma created a review comment on a pull request on flutter/flutter
Should we just `rethrow;` here instead?
loic-sharma created a review comment on a pull request on flutter/flutter
Minor formatting nit: ```suggestion 'You might be having a permissions issue with your IDE. ' 'Please try going to ' 'System Settings -> Privacy & Security...
loic-sharma created a review comment on a pull request on flutter/flutter
Should we only output this error message on macOS?
loic-sharma created a review comment on a pull request on flutter/flutter
Some folks in the thread reported that updating permissions didn't fix the issue ([example](https://github.com/flutter/flutter/issues/150131#issuecomment-2422824717)). Should we include the orig...
loic-sharma created a review comment on a pull request on flutter/flutter
Formatting nits, please: 1. Use two spaces for indentation 2. Add a trailing comma on the last argument 3. For multi-line function calls, but the closing parenthesis on a new line (Can't wa...
loic-sharma opened a draft pull request on flutter/flutter
[SwiftPM] Create separate feature flag for the app migration
⚠️ Do not review; this is an experiment ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygien...
loic-sharma created a comment on a pull request on flutter/engine
I worry this solution might be brittle. Would it be possible to have `et` invoke the compiler from the correct working directory to get the desired output?
loic-sharma created a review on a pull request on dart-lang/pana
Looks great, thanks again for adding this!
loic-sharma created a review on a pull request on dart-lang/pana
Looks great, thanks for adding this!
loic-sharma created a comment on an issue on flutter/flutter
Triage note: we should update `FlutterDesktopViewControllerCreate` to fail (return `nullptr`) if the engine is already owned by another view controller. https://github.com/flutter/engine/blob/70...
loic-sharma created a comment on an issue on flutter/flutter
@bkonyi @andrewkolos Hey there, from a cursory glance this looks like a tool issue. Feel free to reassign back to the Windows team if I'm wrong!