Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
llrs-roche created a branch on insightsengineering/teal.modules.general
1452_datanames@main - General Purpose Teal Modules
llrs-roche created a review on a pull request on insightsengineering/teal.modules.clinical
LGTM: there is a superLinter warning about using only double-quotes
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.clinical
Looks good. Note that on these examples you provided about assertions there is one per argument, not multiple for one argument or that one prevented a different one from raising the issue. Generall...
llrs-roche created a comment on a pull request on insightsengineering/teal
This PR has changes not related to the title. Please restore the RStudio teal.Rproj file. Other than that it is fine. Thanks!
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.general
@vedhav thanks for the message. Yes, I noticed and there is a different issue opened to fix those three modules: #[1452 ](https://github.com/insightsengineering/teal/issues/1452). I'm working to fi...
llrs-roche created a comment on a pull request on insightsengineering/teal.reporter
Thanks Vedha! I updated `rtables.officer` and `rtables` versions
llrs-roche pushed 1 commit to fix_docs@main insightsengineering/teal.reporter
- Update dependencies' versions 52cf6c8
llrs-roche opened an issue on insightsengineering/teal.modules.clinical
[Feature Request]: Improve messages on input validation
### Feature description One user reported on internal forum this error. If one uses a character instead of a data.frame on the `value_choices` for paramcd the user gets a cryptic message `Warning:...
llrs-roche created a branch on insightsengineering/teal.reporter
fix_docs@main - Create and preview reports with Shiny modules
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
If there are duplicated decorators and decorators that won't be used by the module only the first issue will be raised.
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.clinical
The way it is implemented the duplicate naming overrides the messages about names, try with: ``` decorators = list( default = caption_decorator('I am a good caption', 'plot'), ...
llrs-roche created a review on a pull request on insightsengineering/teal.modules.clinical
One minor note before merging to really check for problems with decorators.
llrs-roche created a review on a pull request on insightsengineering/teal.modules.clinical
One minor note before merging to really check for problems with decorators.
llrs-roche created a comment on a pull request on insightsengineering/teal.osprey
Only failing one is "release" with:  ``` Error : ! Could not solve package dependencies: * deps::/tmp...
llrs-roche pushed 1 commit to main insightsengineering/teal.slice
- print invisibly returns the object (#636) 3832ddb
llrs-roche closed an issue on insightsengineering/teal.slice
add return value to `print` methods
According to the documentation of the `print` generic, the function invisibly returns the argument. Our methods for `teal_slice` and `teal_slices` do not. Please rectify this.
llrs-roche closed a pull request on insightsengineering/teal.slice
issue #480 add invisible(x) to `print.teal_slice`
# Pull Request <!--- Replace `#480` with your issue link for reference. --> Fixes #480 (First commit: want to be sure all is OK - Thx.)
llrs-roche created a review comment on a pull request on insightsengineering/teal
Similar to the previous comment, use `with = ` to signal which is the replacement.
llrs-roche created a review comment on a pull request on insightsengineering/teal
I know this was not modified, but there is no need to use `paste`. In addition if you could use `with` it will provide a standard rlang message.
llrs-roche created a review on a pull request on insightsengineering/teal
Changes look good to me: first raising the deprecation and then checking the input. I made some small suggestions to use `deprecate_*(with = )` as I have this fresh from working on other PR, Perhap...
llrs-roche created a review on a pull request on insightsengineering/teal
Changes look good to me: first raising the deprecation and then checking the input. I made some small suggestions to use `deprecate_*(with = )` as I have this fresh from working on other PR, Perhap...
llrs-roche created a comment on an issue on insightsengineering/teal.modules.clinical
If one checks the code produced by teal, the relevant results is calculated by: ```r .... lyt <- rtables::basic_table(title = "Adverse Event summary by : Body System or Organ Class and Dictionary-...
llrs-roche created a review on a pull request on insightsengineering/teal.modules.clinical
I see the expected result: 3/4 pass: 
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.general
Checking again and I see this error message on the example with multiple decorators, but it doesn't seem a problem with the decorators machinery, just the decorator function: ``` .... decorato...
llrs-roche created a comment on an issue on rstudio/chromote
Probably related to this, on updated windows, I see some errors pointing to old headless mode (when testing with Chrome open): ``` packageVersion("chromote") [1] '0.3.1' system.time({devtools::tes...
llrs-roche created a comment on an issue on insightsengineering/teal
`tm_missing_data` has a default `parent_dataname = "ADSL"`, as the data provided doesn't have it, it raises that notification. Previously as datanames or parent_datanames were not passed to `module...
llrs-roche created a review on a pull request on insightsengineering/teal.data
Looks good. Nice addition of the renaming example, I had to double check the last example as I expected `names(td) <- ` to work.
llrs-roche closed an issue on insightsengineering/teal
Remove `set_datanames` functionality
Continuation of https://github.com/insightsengineering/teal/issues/1380#issuecomment-2555532940 ### Summary We will remove the `set_datanames` functionality from the codebase and update a handf...