Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
llrs-roche pushed 1 commit to main insightsengineering/teal.modules.general
- Add ability to set `datanames` (#824) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.git... 1572016
llrs-roche closed an issue on insightsengineering/teal.modules.general
Ability to set `datanames` in module's constructor
### Summary Related to https://github.com/insightsengineering/teal/issues/1436. We need to review all modules to ensure there is a way for users to set `datanames` in the module. Upon revie...
llrs-roche closed a pull request on insightsengineering/teal.modules.general
Add ability to set `datanames`
# Pull Request <!--- Replace `#nnn` with your issue link for reference. --> Fixes #821 This PR add a parameter (or uses existing ones) to use on `teal::module(datanames)` to select which ...
llrs-roche pushed 1 commit to 821_select_datanames@main insightsengineering/teal.modules.general
- Fix broken merge a561700
llrs-roche created a review comment on a pull request on insightsengineering/teal
I understand that on this example there is only one object named `object`, but on the previous documentation it was documented generally: "tables or plots" that is something that is lost with this ...
llrs-roche pushed 3 commits to 821_select_datanames@main insightsengineering/teal.modules.general
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
Suggestion to make it clear the distinction between transformers and decorators ```suggestion #' decorator for tables or plots included in the module output reported. ```
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
All the other changes since my previous feedback look good. I left a minor comment to help users. Not sure of the implications of the changes on `normalize_decorators` but I didn't notice any pr...
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
All the other changes since my previous feedback look good. I left a minor comment to help users. Not sure of the implications of the changes on `normalize_decorators` but I didn't notice any pr...
llrs-roche created a review comment on a pull request on insightsengineering/teal
```suggestion #' decorators for `object`s included in the module. ```
llrs-roche created a review on a pull request on insightsengineering/teal
Looks good, just one minor comment, the current documentation is specific for this example module. Could it be made a bit more general? See suggestion (not sure how if it would render well)
llrs-roche created a review on a pull request on insightsengineering/teal
Looks good, just one minor comment, the current documentation is specific for this example module. Could it be made a bit more general? See suggestion (not sure how if it would render well)
llrs-roche created a comment on an issue on insightsengineering/teal.transform
Related to: https://github.com/insightsengineering/nestdevs-tasks/issues/57 It might not be the best time investment. Or documentation should be updated to point to the replacement appropriately.
llrs-roche created a comment on an issue on insightsengineering/teal
I don't see any duplicated warning on the example code with the current devel versions: , fs1) ```
llrs-roche created a review comment on a pull request on insightsengineering/teal.slice
```suggestion testthat::test_that("print.teal_slice returns argument", { ```
llrs-roche created a review on a pull request on insightsengineering/teal.slice
Yeah, each team have their preferences and methods. I'm sure I would also learn a lot if I contributed or used {admiral}. You are on a great start with {teal}! I left two suggestions to make a t...
llrs-roche created a review on a pull request on insightsengineering/teal.slice
Yeah, each team have their preferences and methods. I'm sure I would also learn a lot if I contributed or used {admiral}. You are on a great start with {teal}! I left two suggestions to make a t...
llrs-roche pushed 4 commits to add_content pharmaR/riskreports
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.general
I can now reproduce the failing checks locally (both on Rstudio R terminal and on the check window pane). Running the tests manually, shows additional information. From this [failing test](https...
llrs-roche created a comment on an issue on insightsengineering/teal.slice
<details> <summary>teal.code: qenv already works as intended</summary> ``` r library("teal.code") q1 <- qenv() q2 <- eval_code(q1, "a <- 1") q3 <- print(q2) #> <environment: 0x000001ece6...
llrs-roche created a review on a pull request on insightsengineering/teal.slice
Hi! Many thanks for your contribution! This is a great start. Could you please update `print.teal_slices` with a similar change? Could you add tests for these changes on the corresponding `...