Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
llrs-roche closed an issue on insightsengineering/teal.modules.clinical
Ability to set `datanames` in module's constructor
### Summary Related to https://github.com/insightsengineering/teal/issues/1436. We need to review all modules to ensure there is a way for users to set `datanames` in the module. Upon revie...
llrs-roche pushed 1 commit to main insightsengineering/teal.modules.clinical
- Show only datasets used (#1309) Co-authored-by: Marcin <[email protected]> Co-authored-by: git... 42135a1
llrs-roche closed a pull request on insightsengineering/teal.modules.clinical
Show only datasets used
# Pull Request Fixes #1307 Only `tm_g_ci` and `tm_g_barcart_simple` didn't have the datanames of the module configurable. I modified `tm_g_ci` and `tm_g_barcart_simple` so that only the da...
llrs-roche pushed 1 commit to 1307_flexible_datanames@main insightsengineering/teal.modules.clinical
- Revert "Rstudio updates" This reverts commit c37422fee0b80ef96e2f017bf776aea001e61ba5. 47704a9
llrs-roche pushed 7 commits to blocking_notes@main insightsengineering/teal.reporter
- feat: allow html content to be added to a report (#294) 81b6103
- [skip actions] Bump version to 0.3.1.9021 81531dc
- upgrade testthat (#297) testthat 3.2.2 is required, to pull waldo 0.6.0 so that compare_proxy function works as exp... bd85e78
- [skip actions] Bump version to 0.3.1.9022 32bb956
- upgrade formatters and rlistings (#298) There is also one more tests failing on dependency tests due to formatters+... 5148d25
- [skip actions] Bump version to 0.3.1.9023 5c18d08
- Merge branch 'main' into blocking_notes@main e23fa3d
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.general
Bisect finished: ``` 4cab9d5cdf6f19d2fd1d33f7712337dbfc1b2f9a was both good and bad error: bisect run failed: 'git bisect good' exited with error code -1 ``` But results don't seem determin...
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.general
I can reproduce the test failing locally now (before they were sporadic/ not consistent) running through all this branch's commits to tests which one broke them (`git bisect run testthat_cli.R` wh...
llrs-roche created a review on a pull request on insightsengineering/teal
The extra-deps fixed the min_isolate check: [before](https://github.com/insightsengineering/teal/actions/runs/12784947499/job/35639440420) vs [after](https://github.com/insightsengineering/teal/act...
llrs-roche closed an issue on pharmaR/riskreports
Fix problems for the CI
On https://github.com/pharmaR/pharmapkgs/pull/17 it has been noted some problems that needs fixed on riskreports or enhancements to make it more useful. Se specially the #FIXME notes like this o...
llrs-roche created a comment on an issue on pharmaR/riskreports
Typo corrected directly on main, and the report works locally from pharmapkgs
llrs-roche created a comment on an issue on pharmaR/riskreports
Running the assessment locally work better but there are still 3 NA: ```r d_riskmetric <- readRDS("inst/assessments/dplyr_local.rds") sort(table(sapply(d_riskmetric, is)), TRUE) ## ## ...
llrs-roche pushed 3 commits to 821_select_datanames@main insightsengineering/teal.modules.general
llrs-roche opened a draft pull request on pharmaR/pharmapkgs
riskreports integration
This PR is to discuss the integration between riskreports and pharmapkgs, discussed a bit on #17 1) The errors generating the report using `riskreports::package_report`: I've tested this PR with...
llrs-roche created a comment on an issue on pharmaR/riskreports
Some dependencies requirements are split in multiple lines (showing up as [being different requirements](https://pharmar.github.io/pharmapkgs/inst/report/validation_report_arrow_v15.0.1.html#depend...
llrs-roche opened a draft pull request on pharmaR/riskreports
Improve the looks of the report
Related to #18
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.general
My 2 cents: On one hand I like that these two arguments doing similar things have similar arguments default that differentiate from the others. On the other hand I would prefer to have NULL as defa...
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.general
I approved the PR mentioned. If there is anything else to improve let me know
llrs-roche pushed 1 commit to 518-pkgs_imports@main insightsengineering/teal.modules.general
- Fix typo 9f4b496
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.general
I thought this could affect the release, and the scheduled CI, so decided to pick it. I updated the PR and fixed a note about lifecycle. ``` Namespace in Imports field not imported from: 'lifec...
llrs-roche pushed 7 commits to 518-pkgs_imports@main insightsengineering/teal.modules.general
- Improvement on decorators (#822) # Pull Request Fixes https://github.com/insightsengineering/coredev-tasks/issues/6... 21226d4
- [skip actions] Bump version to 0.3.0.9062 268a604
- Fix logger (#827) Linked to #insightsengineering/teal.logger/pull/103 bf4b95a
- [skip actions] Bump version to 0.3.0.9063 1fd75a0
- Merge commit '1fd75a0376c9921b271fcd6208d6b64791470220' 4a65519
- Recreate documentation 7e2b01b
- Move lifecycle from Imports to Suggests 10139bf
llrs-roche created a review on a pull request on insightsengineering/teal
The new test passes on this branch and not on main, and this PR also fixes the issue on https://github.com/insightsengineering/teal.modules.general/pull/824#issuecomment-2590020038. I updated the ...
llrs-roche created a review on a pull request on insightsengineering/teal
The new test passes on this branch and not on main, and this PR also fixes the issue on https://github.com/insightsengineering/teal.modules.general/pull/824#issuecomment-2590020038. I updated the ...
llrs-roche pushed 5 commits to fix_error insightsengineering/teal
- Fix logger (#1444) Linked to #insightsengineering/teal.logger/pull/103 1b6916c
- [skip actions] Bump version to 0.15.2.9099 d59e6a0
- 1441 transformators documentation (#1443) Part of https://github.com/insightsengineering/teal/issues/1441 A reviewe... d1706e6
- [skip actions] Bump version to 0.15.2.9100 75198f8
- Merge branch 'main' into fix_error d8d35bc
llrs-roche created a review on a pull request on insightsengineering/teal
The new test passes on this branch and not on main, and this PR also fixes the issue on https://github.com/insightsengineering/teal.modules.general/pull/824#issuecomment-2590020038.
llrs-roche created a review on a pull request on insightsengineering/teal.slice
The matrix changes make sense and the versions requested are current released versions of packages. Not sure why `bioc::MatrixGenerics` was initially needed, but I think it is better to leave it out
llrs-roche created a review on a pull request on insightsengineering/teal.slice
The matrix changes make sense and the versions requested are current released versions of packages.