Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
There are 15 modules: ```bash ls -1 *.R | grep "tm_*" tm_a_pca.Ro tm_a_regression.R tm_data_table.R tm_file_viewer.R tm_front_page.R tm_g_association.R tm_g_bivariate.R tm_g_distribution....
llrs-roche created a review on a pull request on insightsengineering/teal.modules.clinical
36 R files modified, only remaining ones are these: ```bash $ ls -1 | grep -v "^tm_" argument_convention.R arm_ref_comp.R data.R facet_grid_formula.R labels.R string_ops.R substitute_nam...
llrs-roche created a review on a pull request on insightsengineering/teal.modules.clinical
36 R files modified, only remaining ones are these: ```bash $ ls -1 | grep -v "^tm_" argument_convention.R arm_ref_comp.R data.R facet_grid_formula.R labels.R string_ops.R substitute_nam...
llrs-roche pushed 1 commit to main insightsengineering/teal.logger
- fix logger error `All unnamed arguments must be length 1`. (#103) `glue` fails when receives a vector of length > 1.... 536bc50
llrs-roche closed a pull request on insightsengineering/teal.logger
fix logger error `All unnamed arguments must be length 1`.
`glue` fails when receives a vector of length > 1. Message generate with warning could have n-elements and `parse_logger_message` would return a vector instead of a single character. Example ...
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.clinical
@pawelru there seems to be a problem on the Docs/Pkgdown github actions. The action is failing when the required versions are available on the main branch of their repositories (and it continues be...
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.clinical
The the initial lock files are identical. but on the Docs run when the DESCRIPTION file is modified I see: ``` Modify DESCRIPTION file (development) ℹ Loading metadata database ✔ Loading ...
llrs-roche created a review on a pull request on insightsengineering/teal.reporter
Oh, I didn't know that sometimes the release branch is allowed to break. All good then.
llrs-roche created a review on a pull request on insightsengineering/teal
While I agree that is better to have a verb than just repeating the name of the argument, it is still unclear to me what does it mean to transform module's data input. Is there a more specific verb...
llrs-roche created a review on a pull request on insightsengineering/teal.reporter
The new actions still fail with at `⠴ Resolving release version of withr [25/25] ETA: 0s`
llrs-roche created a comment on a pull request on insightsengineering/teal.reporter
I see that you added rlisting version too. But the actions are still failing with: ``` Error in FUN(X[[i]], ...) : subscript out of bounds Calls: fun ... new_release_deps_installation_proposa...
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.general
When I'm re-running the cases above, I'm still facing an issue with the `tm_front_page`, it seems to come from `show_metadata = deprecated()`, I see on the terminal: ``` [WARN] 2025-01-14 15:0...
llrs-roche pushed 1 commit to 821_select_datanames@main insightsengineering/teal.modules.general
- Remove tests c157c80
llrs-roche created a review on a pull request on insightsengineering/teal.logger
Sorry, I forgot to mention this. I think a version bump is in order to make other packages like `tmc` and `tmg` depend on this specific version or above (just thinking on the `tmg` CI failing to re...
llrs-roche created a review on a pull request on insightsengineering/teal.logger
Looks good and works well!
llrs-roche created a review on a pull request on insightsengineering/teal.logger
This solves the issue. I get a warning though: ``` [WARN] 2025-01-14 13:50:54.6885 pid:25376 token:[] teal.code `get_var()` was deprecated in teal.code 0.5.1. Please use `base::get()` instead. ...
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.clinical
Mmh, I though I had answered this, but once it is written it doesn't seem it is overwritten again.
llrs-roche pushed 1 commit to 821_select_datanames@main insightsengineering/teal.modules.general
- Update R/tm_variable_browser.R Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: Lluís ... 8545235
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
Oh, thanks for the reminder. Should be addressed now, I hope the shorter sentence is enough now
llrs-roche pushed 6 commits to 821_select_datanames@main insightsengineering/teal.modules.general
- Import and no reassign d7fe392
- Remove unnecessary NEWS entry 2da5d0b
- Shorter datasets_selected argument and remove the datanames' argument of srv_page_data_table ba2b037
- Use identical instead of != 53ac5be
- Correct typo, shorten datases_selected argument's description, remove datanames argument. 6f08e3d
- Update documentation with feedback and typos corrected cc70989
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
@m7pr I think once it is present it isn't rewritten, but it is true that is different for different machines or setups, mine was different for this PR (not sure how it is decided or how it will be ...
llrs-roche created a review on a pull request on insightsengineering/teal.reporter
Do we really need 0.5.10? It seems formatters 0.5.8 already introduced the `fontspec` argument on `wrap_txt` that is needed according to the tests: https://diffify.com/R/formatters/0.5.5/0.5.8
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.clinical
I'll compare the Docs/ Pkgdown docs dependency problems with the check run, that could solve the dependencies: https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12687811698/...
llrs-roche pushed 2 commits to 821_select_datanames@main insightsengineering/teal.modules.general
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.clinical
Triggering the tests again, as they were mainly dependency setup, then I'll try to fix them locally