Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.clinical
This is a new addition of the latest Rstudio version, not sure if we can't avoid this (I've seen it added by @averissimo in other packages).
llrs-roche pushed 2 commits to 821_select_datanames@main insightsengineering/teal.modules.general
llrs-roche pushed 4 commits to 821_select_datanames@main insightsengineering/teal.modules.general
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
I am not sure, I think I had something longer and somehow a stylr converted to this and then I might have replaced the longer name. In any case I converted it back to one line and it pass the styl...
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
We would need to import lifecycle (tmc, teal and other packages do it) because `lifecycle::deprecated` help pages says "We recommend importing lifecycle::deprecated() in your namespace and use it w...
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
I think we would lose the detailed message we provide to make it easier for users to adapt to this change. I am not sure but this would mean that the message is displayed for all users not just as ...
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
Sorry, I committed this but was half-baked, I'm still wrapping my head to testing with shinytest2 and the changes I made.
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
Sorry, this is part of what I'm working on. Tests are failing, the deprecate (now a warning ) is not shown and there are other errors (not specific of this module).
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
Thanks for the feedback, apologies about the testing section as it is not completed and ready for review yet.
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
Thanks for the feedback, apologies about the testing section as it is not completed and ready for review yet.
llrs-roche created a comment on an issue on insightsengineering/teal.modules.clinical
@jenko1979 I'm not familiar with the part of the code base responsible of these calculations, I hope other people can help you better.
llrs-roche pushed 1 commit to main pharmaR/pharmapkgs
- 16 generate riskreport (#17) Co-authored-by: Lluís Revilla <[email protected]> Co-author... 003ed4b
llrs-roche closed an issue on pharmaR/pharmapkgs
Generate riskreport
For every package that is being scored, we should save the assessment result. Afterwards, this assessment file should be used to generate a report using `riskreports` package.
llrs-roche closed a pull request on pharmaR/pharmapkgs
16 generate riskreport
Closes #16 ## Description This PR adds report generation to the github actions pipeline. Website implementation lies beyond the scope of this PR. Related code can be found [here](https://...
llrs-roche created a comment on an issue on insightsengineering/teal.modules.clinical
I used your data with the development version of teal.modules.clinical and rtables (among others) and run your reproducible example (reprex). When I check the "Display grade groupings in nested ...
llrs-roche pushed 5 commits to 821_select_datanames@main insightsengineering/teal.modules.general
llrs-roche created a comment on an issue on insightsengineering/teal.modules.clinical
Thanks! I am not sure if I will be fixing this or someone else, but in any case it will be easier to not need to pass the data files via email. If it is dummy data can you post the script to creat...
llrs-roche created a comment on an issue on insightsengineering/teal.modules.clinical
Hi, I think I something similar was reported recently but I don't find it now to check if it was fixed or what was done. Thanks for the report. We'll see what we can do.
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
I was about to edit and use `union(datanames, parent_dataname)` here (and for `module(datanames = datanames)`. About your comment I think this is too ambitious for this PR (even if it just internal...
llrs-roche pushed 1 commit to 821_select_datanames@main insightsengineering/teal.modules.general
- Apply suggestions from code review Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: Ll... 59401be
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
Nice catch, will add this back.
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
Ok, will add the `deprecate_soft(details)` and refer to the documentation.
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
Thanks for the new round of comments! I'm struggling testing the deprecate_soft warning, as the warning is not raised because modules are never called from the base environment. How is this usua...
llrs-roche pushed 2 commits to 821_select_datanames@main insightsengineering/teal.modules.general
llrs-roche pushed 1 commit to 821_select_datanames@main insightsengineering/teal.modules.general
- Comment I missed when updating e6e5d10
llrs-roche pushed 3 commits to 821_select_datanames@main insightsengineering/teal.modules.general