Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
Oh, yes this makes code simpler (your other suggestion)
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
Thanks, I'll fix the style checks for the documentation too.
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
Thanks, I'll fix the style checks for the documentation too.
llrs-roche pushed 1 commit to 821_select_datanames@main insightsengineering/teal.modules.general
- Apply suggestions from code review Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: Ll... af4143a
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
Because I thought it would be easier to work with, and there isn't yet an official policy on this matter (cfr: https://github.com/insightsengineering/nestdevs-tasks/issues/86)
llrs-roche pushed 2 commits to 821_select_datanames@main insightsengineering/teal.modules.general
llrs-roche pushed 3 commits to 821_select_datanames@main insightsengineering/teal.modules.general
- Improvement on decorators (#822) # Pull Request Fixes https://github.com/insightsengineering/coredev-tasks/issues/6... 21226d4
- [skip actions] Bump version to 0.3.0.9062 268a604
- Merge branch 'main' into 821_select_datanames@main Signed-off-by: Lluís Revilla <[email protected].... 2708f8f
llrs-roche pushed 9 commits to 821_select_datanames@main insightsengineering/teal.modules.general
- Rename argument 766a3c6
- Rename datasets_selected to datanames b782def
- Deprecate show_metadata and use datanames 18791db
- Update vignette 4a3682c
- Add tests checking deprecated arguments 02e0408
- Add NEWS entry 441d069
- Correct example 677075f
- Style the R files 24537f3
- Remove trailing commas Merge branch '821_select_datanames@main' of https://github.com/insightsengineering/teal.modul... 0bbce3a
llrs-roche created a comment on a pull request on pharmaR/pharmapkgs
I'll merge this, but I wanted to check with you @dgkf (or anyone that knows about this) about calculating the riskmetrics assessment and default score for packages: Should this data be saved to be...
llrs-roche created a review on a pull request on insightsengineering/r-verdepcheck-action
Sorry I didn't catch that earlier. Do you want to set a default?
llrs-roche opened an issue on pharmaR/regulatory-r-repo-wg
Jan 9th, Core team meeting minutes
**Agenda and meeting notes** Attendees: Coline, Doug, Xinyue, Lluís, Pavel, Zhenglei, Damian Apologies: Minutes: @llrs-roche **Meeting notes** - Small talk about the holidays - Phuse/p...
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
Ok, I'll try locally if it is some environmental variable I set up that might trigger this (I have by default more strict criteria for checks than just `--as-cran`)
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
Ok, I'll focus first of fixing the issue of the template and then on this, maybe working on it will help with this
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
No, I took it as a path because I though it would be saved as a file and would be easier to read if passed via the command line. riskreports could accept the object directly (and if anyone wants to...
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
I don't need the score to generate the report, and seeing it here is what throw me a bit off, maybe I'll understand it better in action than on here. What I understood was that the scores would be ...
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
Oh, it is not a problem. But I was wondering if these kind of functions should be on riskreports or here. What is the side effect of the assessment file you mention? Do you mean `riskreports::a...
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
I am testing on Windows, yes. <details> <summary>Traceback from the test:</summary> ``` ══ Failed tests ════════════════════════════════════════════════════════════════ ── Error ('test-re...
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
I need to figure out how to make this easier, because it makes harder to test riskreports and I also got an error while checking the package about stagged installations that lead me to use `StagedI...
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
The test failed locally: ``` ══ Failed tests ════════════════════════════════════════════════════════════════ ── Error ('test-reports.R:6:5'): report generation: works ────────────────────── ...
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
Why is a new function needed to generate the report? The major difference/value I see is that you allow to move the report to a different folder. This can be added easily to `riskreports::package_r...
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
Reports don't use score, because it was decided each company would need to evaluate and decide the level of risk they tolerate or how they calculate the risk. Is this calculated here so that it can...
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
Simplify the mapply call: ```suggestion mapply(make_one_report, pkg_reference, pkg_assessment, output_dir) ```
llrs-roche created a review comment on a pull request on pharmaR/pharmapkgs
v2 is no [longer supported](https://github.com/actions/checkout) and I'm not sure it works well on all machines: ```suggestion - uses: actions/checkout@v4 ```
llrs-roche created a review on a pull request on pharmaR/pharmapkgs
I left multiple comments the major one is perhaps why not use the riskreports function directly? But this also points to a problem with the quarto document riskreports is using :(