Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
llrs-roche created a review on a pull request on pharmaR/pharmapkgs
I left multiple comments the major one is perhaps why not use the riskreports function directly? But this also points to a problem with the quarto document riskreports is using :(
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.general
> Exactly! Only objects that appear on the reporter are decorated. This also connects with the screenshot below My memory is getting back after holidays :D . Ok with reverting decorators at `tm_da...
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
I will do that and check what happens with `transformators`.
llrs-roche pushed 1 commit to main pharmaR/riskreports
- Generate all formats of the reports Let the template file decide which formats to render. 771f0f9
llrs-roche closed a pull request on pharmaR/riskreports
Update reporter.R
Let the template file decide which formats to render.
llrs-roche opened an issue on pharmaR/riskreports
Presentation of the report
The report is for three groups of people: - non-technical people: leadership and decision-makers - technical people not familiar with the package and - technical people familiar with the pack...
llrs-roche created a comment on a pull request on insightsengineering/teal.modules.clinical
I'm seeing some problems on the CI about conflict versions on #1309, and [here too](https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12684296437/job/35352731321?pr=1308#ste...
llrs-roche created a comment on an issue on pharmaR/riskreports
I use the canon CRAN repository to check packages locally. This could also be fixed on riskmetric, as I found on several issues with how it read packages sources (https://github.com/pharmaR/riskm...
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
I went with what is used in other modules, currently there are 2 modules using this argument: `tm_data_table` and `tm_variable_browser`. Let me know if you want me to rename those other modules too...
llrs-roche created a comment on an issue on pharmaR/riskreports
@Gotfrid Do you think that the assessment generated by the CI could reduce the number of errors? The current file provided has very little information to write a good report. I got more results run...
llrs-roche created a comment on a pull request on pharmaR/riskreports
Currently the focus is more on the content of the report than the format, using "all" is better but will make the CI slower and more complicated if the default template creates a pdf (LaTeX, Typst,...
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
On that condition `show_metadata` prevails and nothing would be shown... but I can deprecate `show_metadata` entirely.
llrs-roche pushed 1 commit to 1307_flexible_datanames@main insightsengineering/teal.modules.clinical
- Change style 754dfd0
llrs-roche opened a pull request on insightsengineering/teal.modules.clinical
Show only datasets used
# Pull Request Fixes #1307 Only `tm_g_ci` and `tm_g_barcart_simple` didn't have the datanames of the module configurable. I modified `tm_g_ci` and `tm_g_barcart_simple` so that only the da...
llrs-roche created a branch on insightsengineering/teal.modules.clinical
1307_flexible_datanames@main - Provides teal modules for the standard clinical trials outputs
llrs-roche created a comment on an issue on insightsengineering/teal.modules.clinical
There are 36 exported modules from tmg, only those `tm_g_barchart_simple` and `tm_g_ci` have set `datanames = "all"`, other have it configurable:  has this tally: ```r d_riskmetric <- readRDS("inst/assessments/dplyr.rds") sort(table(sapply(d_riskmetric, is)), TR...
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
I think on this case it makes more sense to keep it as an inline function.
llrs-roche created a review comment on a pull request on insightsengineering/teal.modules.general
Typos: ```suggestion #' (`list` of `teal_transform_module`, named `list` of `teal_transform_module` or `NULL`) optional, ```
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
> tm_data_table: decorators removed Sorry, I don't recall why we remove decorators only on this module. Could you remind me? Is it because it cannot be used with a reporter? > tm_missing_...
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
> tm_data_table: decorators removed Sorry, I don't recall why we remove decorators only on this module. Could you remind me? Is it because it cannot be used with a reporter? > tm_missing_...
llrs-roche pushed 1 commit to main pharmaR/riskreports
- Keep inst/reports (#15) Due to the fact that inst/report is ignore in R build, this folder does not exist when the p... 5ed796b
llrs-roche closed a pull request on pharmaR/riskreports
Update .Rbuildignore
Due to the fact that inst/report is ignore in R build, this folder does not exist when the package is installed: ```r list.files(system.file(package = "riskreports")) # [1] "DESCRIPTION" "help" ...
llrs-roche created a comment on a pull request on pharmaR/riskreports
Thanks for catching that. I was having troubles with some code but wasn't sure were it came from.