Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
llrs-roche created a review on a pull request on insightsengineering/teal.modules.general
I left a couple of comments, as I haven't checked the code locally yet
llrs-roche created a review on a pull request on insightsengineering/teal
Sorry, I forgot to aprove yesterday!
llrs-roche pushed 1 commit to main insightsengineering/rtables
- Rename logo to be displayed (#979) Apologies, I left the change uncommitted when I pushed on #978 with this PR the l... eb08460
llrs-roche closed a pull request on insightsengineering/rtables
Rename logo to be displayed
Apologies, I left the change uncommitted when I pushed on #978 with this PR the logo should display correctly  The previous PR used the logo already present on the repository which was old. Th... f00b63a
llrs-roche closed a pull request on insightsengineering/rlistings
Replace old logo by new one
The previous PR used the logo already present on the repository which was old. This PR replaces it by the new one, which is correctly displayed on github branch:  - scripts/save_logos.R: To copy those logos to the repositories of packages at the ...
llrs-roche created a review on a pull request on insightsengineering/teal
I am not sure about the visual changes on the Transformators (Why was there in the first place?) But all the other changes look good. I tested also on a white background and it looks good
llrs-roche created a review on a pull request on insightsengineering/teal
I am not sure about the visual changes on the Transformators (Why was there in the first place?) But all the other changes look good.
llrs-roche created a review comment on a pull request on insightsengineering/teal
I was thinking this code will be executed mostly by developers checking & testing the package, so that should be checked first as it can lead to speed improvements and code readability. I think t ...
llrs-roche created a review on a pull request on insightsengineering/teal
The code works well, but I am not sure about the readability (but I also don't think my proposal is easier to read)...
llrs-roche created a review on a pull request on insightsengineering/teal
The code works well, but I am not sure about the readability (but I also don't think my proposal is easier to read)...
llrs-roche opened a pull request on insightsengineering/rtables
Rename logo to be displayed
Apologies, I left the change uncommitted when I pushed on #978 with this PR the logo should display correctly : ![im...
llrs-roche created a branch on insightsengineering/chevron
renaming_logo@main - Standard TLGs For Clinical Trials Reporting
llrs-roche pushed 3 commits to svg_logo@main insightsengineering/chevron
llrs-roche created a branch on insightsengineering/chevron
svg_logo@main - Standard TLGs For Clinical Trials Reporting
llrs-roche created a review comment on a pull request on insightsengineering/chevron
Thanks Pavel! I think I missed renaming the file to logo.svg or maybe we are stuck with png for github to show the logo as `usethis::use_logo` only uses PNG. I'll be checking this on all repos.
llrs-roche closed an issue on insightsengineering/teal
Request for renames in `teal_data_module`
Follow-up on https://github.com/insightsengineering/teal/pull/1253 Please find below a list of objects which names I personally found confusing. If you agree - let's try to find a good name. ...
llrs-roche pushed 1 commit to main insightsengineering/teal
- Rename teal_data_module.R functions (#1430) # Pull Request Renamed parameters to data, and renamed data_rv, filte... 02edb14