Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
kriswest created a review comment on a pull request on finos/FDC3
Dropping it, I aborted an attempt to standardize the language/correct the grammar in some of the test steps ('I call "object" with "functionName" with "parameter"' doesn't sit right with me), but I...
kriswest created a review comment on a pull request on finos/FDC3
Yeah lets change that to `messageExchangeTimeout`
kriswest created a review comment on a pull request on finos/FDC3
So... I _think_ you want these to be different between the implementation and tests. You need to use _/dist/_ in the implementation(s) as the src dir doesn't exist in the NPM module but dist does, ...
kriswest created a review comment on a pull request on finos/FDC3
Different timeouts - message exchange vs. DA discovery. Changing the name to MESSAGE_EXCHANGE_TIMEOUT_MS (as you suggest) will resolve.
kriswest created a review comment on a pull request on finos/FDC3
It's extracting the settings specific to the proxy, and yes does need to reapply defaults if an object was passed without them.
kriswest created a review comment on a pull request on finos/FDC3
They are, but if someone sets the logging element and leaves out that property it ends up undefined. TypeScript doesn't prevent that as its third-party code setting the options.logging object - but...
kriswest created a review comment on a pull request on finos/FDC3
Will await a decision on the comment above first as that would change it setting a log level.
kriswest created a review comment on a pull request on finos/FDC3
Could you take a closer look at that suggestion - the problem with it is that if you want to be able to disable heartbeat logging separately from other debug logging (and you need to as the heartbe...
kriswest created a comment on a pull request on finos/FDC3
> Just looking at code coverage, I see cleanup() being called on all the MessageHandelrs except the HeartbeatHandler - any idea why? The function should be getting called but it has no body, jus...
kriswest created a review on a pull request on finos/FDC3
Generally LGTM and test up fine, just some stray newlines added to the changelog that need removing then this is ready to merge. I did note that originating app metadata is not being published o...
kriswest created a review comment on a pull request on finos/FDC3
I suspect this was not intended ```suggestion ```
kriswest created a review on a pull request on finos/FDC3
Generally LGTM and test up fine, just some stray newlines added to the changelog that need removing then this is ready to merge. I did not that originating app metadata is not being published on...
kriswest created a review on a pull request on finos/FDC3
Generally LGTM and test up fine, just some stray newlines added to the changelog that need removing then this is ready to merge. I did not that originating app metadata is not being published on...
kriswest pushed 1 commit to fdc3-for-web-impl-control-timeouts finos/FDC3
- switch existing test to new error message (as its an APITimeout rather than the app timing it - Desktop Agent should ... 4250222
kriswest created a comment on a pull request on finos/FDC3
I had to merge the debug logging PR into this one to figure out the tests (need debug output from the proxy messages). After doing so I realized that every call to broadcast on the current user ...
kriswest created a comment on a pull request on finos/FDC3
@robmoffat I think this and the new tests are working well now. N.b. I needed to test from the fdc3-get-agent package (although the timeouts are in the fdc3-agent-proxy package) as the custom t...
kriswest pushed 5 commits to fdc3-for-web-impl-control-timeouts finos/FDC3
- Fixing packaging and deployment of Reference UI for Web f709255
- Using hosted channel selector and intent resolver. d2bb607
- Remove unused files originally written for early development 2a185a5
- fixed dup in test policy 3abc5cb
- Merge branch 'fdc3-for-web-impl' into fdc3-for-web-impl-control-timeouts 12df506
kriswest pushed 24 commits to fdc3-for-web-impl-control-timeouts finos/FDC3
- Added test policy in contributing section 1e0774b
- added changelog 48b93e4
- Update CONTRIBUTING.md 8162392
- Update CONTRIBUTING.md ee7f931
- Update CONTRIBUTING.md Co-authored-by: Kris West <[email protected]> 67356c1
- Adding support for controlling debug logging in fdc3-agent-proxy and fdc3-get-agent 19a3aad
- CHANGELOG 19a0f8e
- Testing coverage a44ec5d
- Test coverage dca1f8a
- Merge pull request #1480 from finos/fdc3-for-web-impl-test-policy Fdc3 for web impl test policy 6ccd641
- Added dist, bumped to alpha.2 version 5ff5066
- updated to alpha.3 9e05c46
- Update website/docs/api/ref/GetAgent.md 1ed86d8
- Merge branch 'main' into fdc3-for-web-impl cbda003
- Apply prettier after generating files from schemas At various times we've committed the generated source files with ... 4ff303f
- Merge branch 'fdc3-for-web-impl' into fdc3-for-web-impl-debug-logs 5dcffda
- Merge branch 'main' into fdc3-for-web-impl f9faca9
- Migrate conformance test docs into correct location in mono repo 029f617
- Merge branch 'fdc3-for-web-impl' into fdc3-for-web-impl-debug-logs 0644c81
- Creating ApiTimeout errors and partially complete tests ca3daad
- and 4 more ...