Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
kriswest created a review comment on a pull request on finos/FDC3
I intend to remove it and replace with a custom implementation - this was a result of my frustration at not finding a lib for this that would build under both es6 and commonjs. I was going to do th...
kriswest created a comment on a pull request on finos/FDC3
> This is pointing to conformance where really it should be the local appd line (reverse the commenting) Fixing that.
kriswest created a comment on a pull request on finos/FDC3
> Ok, one more UI thing, the default channel appears to be white now, instead of black. But that makes it hard to see against the workbench: ... > Obviously, if workbench was running in dark ...
kriswest created a comment on an issue on finos/FDC3
We've resolved to go with an ES6 build for @finos/fdc3 and to create and publish a new module for backwards compatibility @finos/fdc3-common
kriswest closed an issue on finos/FDC3
CommonJs vs ES6
For Background: @Lecss @kriswest and I built the "combined" @finos/fdc3 module in the FDC3 repo, combining all the other modules. For now, this uses ES6 module structure, rather than the FDC3 r...
kriswest closed an issue on finos/FDC3
FDC3 Identity & Threat Modelling Meeting - Dec 12, 2024
## Date Thursday 12 Dec 2024 -4pm UTC ### Zoom info - **[Join Zoom Meeting](https://zoom.us/j/96940294948?pwd=SjFibVdiN25QSWxva3FqRHY2RUFCdz09)** - **Meeting ID:** 969 4029 4948 - **Passcode...
kriswest created a comment on a pull request on finos/FDC3
@robmoffat the UIs are fixed - they needed some work on timing and I found a couple of the old iframe messages (that we replaced with Fdc3UserInterface) in the demo implementations. I was able to c...
kriswest pushed 3 commits to fdc3-for-web-impl-getAgent-refactor finos/FDC3
kriswest pushed 1 commit to fdc3-for-web-impl-getAgent-refactor finos/FDC3
- Fix getAgent tests after previous change to fdc3-for-web-impl b6b04e1
kriswest created a review comment on a pull request on finos/FDC3
fixed both findIntent and findIntentForContext and added tests
kriswest created a review comment on a pull request on finos/FDC3
This is fixed. I did have to link the ServerContext to its server to do so as if the termination comes from the ServerContext it needs to tell the server and handlers, if it comes from the heartBea...
kriswest pushed 5 commits to fdc3-for-web-impl-getAgent-refactor finos/FDC3
- Better validation of addContextListener args and testing of error on invalid args 31c0781
- Revert to importing all of BrowserTypes as CommonJS compile doesn't like them 50a4731
- Addressing review comments including using appState.terminated for past connections d248137
- Refining fdc3-for-web-impl's findIntent fns, tests and cleanup on disconnection ec14275
- rolling package verison numbers 1cb72b9
kriswest created a review comment on a pull request on finos/FDC3
only in findIntent, looks like it was missing in findIntentForContext. Incidentally on findIntent it looks like, if there are instances running, it only returns those and not the the record with...
kriswest created a review comment on a pull request on finos/FDC3
ug, theres more than an uncovered line to sort here - the tests don't cover multiple results for findIntentsByContext and are not picking up the fact that every app with an intent registered is bei...
kriswest created a review comment on a pull request on finos/FDC3
It does, have manually broken it to make sure the test will catch a lack of cleanup and it appears to.