Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
kirkrodrigues opened a pull request on y-scope/log4j2-appenders
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues opened a pull request on y-scope/clp-loglib-py
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues opened a pull request on y-scope/clp-ffi-py
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues opened a pull request on y-scope/logback-appenders
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues opened a pull request on y-scope/clp-ffi-java
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues opened a pull request on y-scope/yscope-log-viewer
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues opened a pull request on y-scope/fluent-bit-clp
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues opened a pull request on y-scope/log-surgeon
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues opened a pull request on y-scope/log4j1-appenders
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues opened a pull request on y-scope/clp-ffi-go
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues pushed 1 commit to update-pr-template kirkrodrigues/clp-ffi-py
- chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`. 992ca57
kirkrodrigues pushed 1 commit to update-pr-template kirkrodrigues/yscope-docs
- Remove unrelated changes. 5657a63
kirkrodrigues opened a pull request on y-scope/yscope-docs
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion constexpr std::string_view cCompressionTypeZstd{"ZSTD"}; ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion ``` Generally we don't document thrown exceptions, except at the boundary of a library, for the following reasons: * C++ exceptions propagate through functions, so tracing ever...
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * Packs this instance into a MessagePack object and writes it to the open file. * * @param file_writer ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * Reads serialized MessagePack data from a file and unpacks it into an `ArchiveMetadata` * instance. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * @param path ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion // We need a default constructor to convert from a msgpack::object in `create_from_file`. See ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion #include <msgpack.hpp> ``` Should use `<>` for library includes.
kirkrodrigues created a review comment on a pull request on y-scope/clp
Can we add these in another PR? Switching to MessagePack and adding the new fields are kind of unrelated changes.
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion msgpack::object_handle const oh = msgpack::unpack(buf.data(), buf.size()); msgpack::object const obj = oh.get(); ``` Resolves clang-tidy warnings.
kirkrodrigues created a review comment on a pull request on y-scope/clp
Nit: How about `obj_handle`?
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion clp::Array<char> buf{static_cast<size_t>(file_stat.st_size)}; ``` * We should use brace init. * Brace init results in a compilation error due to the implicit conversion (pre...
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion FileReader file_reader{std::string(path)}; ``` * Using `auto` in this case is more verbose and unnecessary since we need to explicitly specify the type anyway. * We should ...
kirkrodrigues created a review comment on a pull request on y-scope/clp
Generally, exceptions should only be used for exceptional circumstances. I don't think corrupt data is exceptional since it can occur under normal circumstances (e.g., an interrupted download, a dr...