Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Would that be straightforward to do given that the log events collection changes based on the active filter? If not, then given how rare the case is (as far as we know), I'm not sure the extra code...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Seems like it. Not sure how that happened.
kirkrodrigues pushed 1 commit to main y-scope/spider
- chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`. (#62) b72910e
kirkrodrigues closed a pull request on y-scope/spider
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.conventionalc...
kirkrodrigues pushed 1 commit to main y-scope/clp-ffi-js
- chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`. (#55) b4a6791
kirkrodrigues closed a pull request on y-scope/clp-ffi-js
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.convent...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Since the case with out of order timestamps is rare (as far as we know), we could maybe do something like: - When decoding the file, keep track of whether the timestamp of two consecutive log ev...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Right, idx vs num is a good point. I think I still prefer *not* including `idx` for a few reasons: - `find_nearest_log_event_idx` makes it sound like we're looking for an index that's nearest to...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Oh, isn't `FilteredLogEventIdx` also [defined](https://github.com/y-scope/yscope-log-viewer/blob/main/src/typings/decoders.ts#L36) in the Log Viewer? It's true that the name in clp-ffi-js doesn't i...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
I do prefer that, but what do @davemarco / @junhaoliao think?
kirkrodrigues created a review comment on a pull request on y-scope/clp
If we keep these inside the namespace, we should remove the prefix `c` to follow the convention of the other constants in this file (again, this is an exception to our clang-tidy rules).
kirkrodrigues created a review comment on a pull request on y-scope/clp
> Also in general it seems like people are recommending to me to move to new clang-tidy even in old files. But maybe this is not our recommendation? It's our recommendation in other cases. In th...
kirkrodrigues created a review comment on a pull request on y-scope/clp
The current convention for constants in this file is to name the namespace as `cNamespace` and then the constants inside as `ConstantXxx`. I know that disagrees with our clang-tidy rules, but in th...
kirkrodrigues created a review comment on a pull request on y-scope/clp
Based on my original comment: > a field that's unused and meaningless to the public code but can be used by the private code I was expecting we'd implement the private version as a reserved f...
kirkrodrigues opened a pull request on y-scope/spider
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
\u003c\!-- markdownlint-disable MD012 --\u003e\n\n\u003c\!--\nSet the PR title to a meaningful commit message that:\n\n* is in imperative form.\n* follows the Conventional Commits specification (ht...