Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Ah, the branching strategy in the Java repos is just as a way to stage the release before tagging and releasing it. In those repos, we don't publish the release version update to the main branch, s...
kirkrodrigues created a comment on a pull request on y-scope/clp
Can we close this now that #618 & #630 were merged?
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion path: "dist/" if-no-files-found: "error" retention-days: 1 ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Why do we need to create a branch?
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
How about `publish-to-npm`?
kirkrodrigues created a review comment on a pull request on y-scope/clp
How about `invalid_value` instead of `invalid_input`?
kirkrodrigues created a review comment on a pull request on y-scope/clp
How about this instead? ```suggestion auto assert_invalid_serialization = [&]<typename T>(T invalid_input) -> bool { std::map<string, T> const invalid_map{{"valid_key", invalid_inp...
kirkrodrigues created a review comment on a pull request on y-scope/clp
Can we perhaps make this a Catch2 assertion since it would be caused by an error in the test code itself, right?
kirkrodrigues created a review comment on a pull request on y-scope/clp
Can we add a Catch2 assertion to check that the buffer that's passed in is empty?
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * @param buffer A buffer containing a msgpack byte sequence that cannot be serialized into the * KV-pair IR format. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * @return Whether serialization failed and the underlying IR buffer remains empty. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * Unpacks the given bytes into a msgpack object and asserts that serializing it into the KV-pair IR * format fails. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * @return Whether serialization succeeded. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * Serializes the given msgpack map using a depth-first search (DFS). ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion // Validate array ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion // Validate map ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * @return true if the array is serializable. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * - Any value inside the array an unsupported type (i.e., `BIN` or `EXT`). * - Any value inside the array has type `MAP` and the map has non-string keys. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
```suggestion * Checks whether the given msgpack array can be serialized into the key-value pair IR format. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp
I would use `ErrorCode_Failure` since this condition shouldn't only be hit if there's a programming error. `ErrorCode_NoMem` seems misleading since if we truly couldn't allocate the buffer, then th...
kirkrodrigues created a comment on a pull request on y-scope/yscope-log-viewer
> With just "Z" in the title there could be a lack of context. shall we mention the "date"? e.g., > > ``` > fix(editor): Make "Z" suffix optional in the custom Monaco log language's date defini...
kirkrodrigues created a review on a pull request on y-scope/yscope-log-viewer
For the PR title, how about: ``` fix(editor): Make "Z" suffix optional in the custom Monaco log language definition (fixes #149). ```