Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
karelhala closed a pull request on RedHatInsights/sources-ui
chore(deps): update konflux references
This PR contains the following updates: | Package | Change | |---|---| | quay.io/konflux-ci/tekton-catalog/task-apply-tags | `2c2d88c` -> `fa7aa88` | | quay.io/konflux-ci/tekton-catalog/task-build...
karelhala pushed 1 commit to master RedHatInsights/api-frontend
- chore(deps): update konflux references (#688) Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.n... 1105d3d
karelhala closed a pull request on RedHatInsights/api-frontend
chore(deps): update konflux references
This PR contains the following updates: | Package | Change | |---|---| | quay.io/redhat-appstudio-tekton-catalog/task-apply-tags | `6923629` -> `cd8cf87` | | quay.io/redhat-appstudio-tekton-catalo...
karelhala pushed 1 commit to master RedHatInsights/widget-layout
- chore(deps): update konflux references (#136) Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.n... 3cc8774
karelhala closed a pull request on RedHatInsights/widget-layout
chore(deps): update konflux references
This PR contains the following updates: | Package | Change | |---|---| | quay.io/konflux-ci/tekton-catalog/task-apply-tags | `2c2d88c` -> `fa7aa88` | | quay.io/konflux-ci/tekton-catalog/task-build...
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Let's use the JS client for this function as well.
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Extra function body ```suggestion const onCheckboxToggle = () =>updateNotificationSelected(notification.id, !notification.selected); ```
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Same as with the `to` links. I think we can remove the `/settings` URL. But I'd have to check this locally to see what can remain and what can be removed.
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Let's move this file to `__tests__` folder.
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Extra function body ```suggestion onClick={() => onUpdateSelectedStatus(false)} ```
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Since we are in the notifications application I think all links needs to be updated and the `/settings` should be removed. I would have to however have to check it locally what needs to remain and ...
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Extra function body ```suggestion onClick={() => onUpdateSelectedStatus(true)} ```
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
We have the JS client for notifications installed. Let's update the `notificationsApi` to include drawer endpoint and use it here instead of axios get.
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Same as above, we do have the JS clients available, so we can add the bundles link to it and use it here as well.
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Same as with fetch drawer data and facets. Let's use the JS client.
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Can we break this into a new file? Having multiple components in one file makes it harder to debug and read.
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
It might be better to change this function to be `getSomeDaysAgo`? So we can get exact dates back?
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
We are using redux in notifications application, so it might be better to change the state logic to it so we don't have 2 different state management systems.
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
Notifications application is using Redux. I don't think it's reasonable to add Jotai while adding a the drawer to it.
karelhala created a review comment on a pull request on RedHatInsights/notifications-frontend
This PR should not add cypress config. We have a seperate ticket for that work.
karelhala created a review on a pull request on RedHatInsights/notifications-frontend
Other than removing the cypress config, changing Atoms to Redux and utilizing JS clients just a few minor improvements.
karelhala created a review on a pull request on RedHatInsights/notifications-frontend
Other than removing the cypress config, changing Atoms to Redux and utilizing JS clients just a few minor improvements.
karelhala created a review on a pull request on RedHatInsights/insights-chrome
Looking good! Just a couple minor comments.
karelhala pushed 1 commit to master RedHatInsights/insights-chrome
- make feedback text input area auto resizable (#2998) 5555ae8
karelhala closed a pull request on RedHatInsights/insights-chrome
make feedback text input area auto resizable
Jira: https://issues.redhat.com/browse/RHCLOUD-36816 <img width="737" alt="Screenshot 2025-01-23 at 10 21 36 AM" src="https://github.com/user-attachments/assets/cf61454e-982e-403f-8072-9a47f6cc3...