Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
junhaoliao created a comment on a pull request on y-scope/yscope-log-viewer
(no rush; whenever you have time; preferably after your vacation) hey @Henry8192 , if the PR is ready for review, can you resolve all conflicts and fill out the PR description? then please request...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
I agree @davemarco 's suggestion is an improvement
junhaoliao created a review comment on a pull request on y-scope/clp
right, let's do something like ```ts export default fastifyPlugin(async (app, options) => { const {xxx} = options; if (xxx is invalid) { // if throwing halts the server (please...
junhaoliao created a review comment on a pull request on y-scope/clp
Sorry for overlooking this enablement check mechanism when we discussed this offline. Some changes can be made to make the code even cleaner, if you also agree: 1. Let's treat this callback provid...
junhaoliao created a review on a pull request on y-scope/clp-ffi-py
the pr title is fine to be used as the final commit message
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-py
```suggestion :return: JSON string of the serialized dictionary. ```
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-py
Though, it does seem in the Serializer we do permit users to provide a `None` or "{}" value. I haven't traced down to the CLP code but I think the given metadata string will be encoded as-is?
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-py
I agree with the rabbit if we're to accept a `str` type metadata.
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-py
I think an easier to use interface is to accept a dict type. If we're time-constraint to implement that, that's fine.
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-py
sorry for not being able find any previous discussions on this - we have considered the https://github.com/pybind/pybind11_json and other alternatives discussed at https://www.github.com/nlohmann/j...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-py
Would there be less handling for API users if we return an **empty dictionary** if "user-defined stream-level metadata was not given in the deserialized IR stream"?
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-py
If the type of this JSON value is not an object, it means either the file is not created using a Serializer we provide, or something went wrong in our code, right? Though i imagine such cases ar...
junhaoliao created a branch on junhaoliao/yscope-log-viewer
new-http-utils - A tool that can be used to view logs compressed in CLP's IR Stream format.
junhaoliao pushed 2 commits to profile junhaoliao/yscope-log-viewer
junhaoliao created a review on a pull request on y-scope/clp-ffi-py
approving given all tests passed
junhaoliao created a comment on an issue on y-scope/clp
Alternatively, for the issue in #693 specifically, a linter rule can be added to disallow syntaxes that are only available in newer Python versions, if such rules exist.
junhaoliao created a comment on an issue on y-scope/clp
@coderabbitai let's add a follow-up issue (feature request) to add CLP package launching to the PR check workflow
junhaoliao created a review comment on a pull request on y-scope/clp
for consistency, we shall use the `JOB_` prefix. ```suggestion INDEX `JOB_UPDATE_TIME` (`update_time`) USING BTREE ``` on a separate note, i agree "last update time" is mo...
junhaoliao created a review comment on a pull request on y-scope/clp
nit ```suggestion FROM_UNIXTIME(${lastUpdateTimestampSeconds}) - 1 ```