Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
johnjasa pushed 7 commits to develop NREL/GreenHEART
- switch to the PyPI listed ProFAST ba63cdf
- bump version a038221
- fix failing test with pytest.approx 65d41ab
- update changelog 9b2d49a
- fix conflicts 8f3cda7
- udpate changelog per PR conversation and unbump version 524355a
- Merge pull request #36 from RHammond2/patch/profast-release Patch: Update ProFAST requirement to PyPI listing 3be2a01
johnjasa closed a pull request on NREL/GreenHEART
Patch: Update ProFAST requirement to PyPI listing
<!-- IMPORTANT NOTES Is this pull request ready to be merged? - Do the existing tests pass and new tests added for new code? - Is all development in a state where you are proud to share it wi...
johnjasa created a comment on a pull request on NREL/GreenHEART
Got it, yes let's switch to develop as the [main other changes](https://github.com/NREL/GreenHEART/compare/main...develop) are also from reducing dependencies; removing `electrolyzer` and pip-insta...
johnjasa pushed 6 commits to develop NREL/GreenHEART
- Merge pull request #32 from NREL/develop Merging develop into main for v0.1.1 aa329cf
- remove dependence on electrolyzer repository 4e8f524
- remove extraneous import 8a3ca94
- remove electrolyzer repo installation instructions 05a3586
- Removed more electrolyser install notes ef1b883
- Merge pull request #33 from jaredthomas68/remove-electrolyzer-component Remove electrolyzer component 4d09063
johnjasa closed a pull request on NREL/GreenHEART
Remove electrolyzer component
<!-- IMPORTANT NOTES Is this pull request ready to be merged? - Do the existing tests pass and new tests added for new code? - Is all development in a state where you are proud to share it wi...
johnjasa created a review comment on a pull request on NREL/GreenHEART
I'm not sure immediately; maybe this? https://gist.github.com/mamchenkov/930900?permalink_comment_id=3620234#gistcomment-3620234
johnjasa created a review comment on a pull request on NREL/GreenHEART
I think just scipy added in would be the minimum. Rest would depend on which technologies people are using.
johnjasa pushed 1 commit to remove-electrolyzer-component jaredthomas68/GreenHEART
- Removed more electrolyser install notes ef1b883
johnjasa pushed 1 commit to add_soec johnjasa/HOPP
- Working on SOEC outputs for slides for Green Steel 4b1852c
johnjasa pushed 2 commits to add_soec johnjasa/HOPP
johnjasa pushed 2 commits to develop NREL/GreenHEART
johnjasa closed a pull request on NREL/GreenHEART
Enhancement: Log CI build environment settings
<!-- IMPORTANT NOTES Is this pull request ready to be merged? - Do the existing tests pass and new tests added for new code? - Is all development in a state where you are proud to share it wi...
johnjasa created a review on a pull request on NREL/GreenHEART
This is slick, thanks Rob! Exactly what I was picturing.
johnjasa created a review comment on a pull request on NREL/GreenHEART
```suggestion ## Related issues ```
johnjasa created a review comment on a pull request on NREL/GreenHEART
```suggestion Replace the below example with any added or modified files, and briefly describe what has been changed or added, and why. ```
johnjasa created a review comment on a pull request on NREL/GreenHEART
Love this, I chatted with Raf and he said something like this was quite helpful for floris dev
johnjasa created a review comment on a pull request on NREL/GreenHEART
```suggestion problem. All code and full tracebacks should be properly markdown formatted.> ```
johnjasa created a review comment on a pull request on NREL/GreenHEART
```suggestion <!--The title should clearly define the feature request/enhancement succinctly.--> ```
johnjasa created a review comment on a pull request on NREL/GreenHEART
```suggestion Use `pip freeze` to gather the relevant versions, and use the markdown table formatting as ```
johnjasa created a review comment on a pull request on NREL/GreenHEART
Add scipy version? Any others?
johnjasa created a review comment on a pull request on NREL/GreenHEART
Add a note that if you're on a developer install to include the commit hash?
johnjasa created a review on a pull request on NREL/GreenHEART
I like these changes! Especially the checklist. Very minor wordsmithing suggestions from me
johnjasa created a review on a pull request on NREL/GreenHEART
I like these changes! Especially the checklist. Very minor wordsmithing suggestions from me