Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jcheng5 pushed 1 commit to deep-stack-limit rstudio/shiny
- Use deep stack deduplication instead of elision This hopefully will avoid any potential ..stacktraceon../off.. scori... ea6d093
jcheng5 created a review comment on a pull request on rstudio/shiny
This is the main thing I want to discuss with you this afternoon
jcheng5 created a review comment on a pull request on rstudio/shiny
I handled this slightly differently so we don't go through the `stripStackTraces` code path at all if `full` is true.
jcheng5 pushed 1 commit to deep-stack-limit rstudio/shiny
- Don't call stripStackTraces if we're not stripping a533b05
jcheng5 created a review comment on a pull request on rstudio/shiny
It started out that way, I added a big comment explaining why it needs to be the way it is.
jcheng5 pushed 1 commit to deep-stack-limit rstudio/shiny
- Add more comments, refine dropTrivialTestFrames 019e188
jcheng5 pushed 1 commit to deep-stack-limit rstudio/shiny
- Rename keep_head to retain_first_n e032b80
jcheng5 created a review comment on a pull request on rstudio/shiny
I decided not to turn this into a for-loop after all; after fixing the stripStackTrace scoring issue (thanks for catching that, btw) the mapply is actually useful as we're now iterating over 3 thin...
jcheng5 created a review comment on a pull request on rstudio/shiny
I tried `elide_position` but it's awkward for callers. I think "how many elements at the front do you want to keep?" is more natural to think about than "from what position do you want to start per...
jcheng5 created a review comment on a pull request on rstudio/shiny
I fixed this, but it's not perfect; eliding deep stack traces may screw up the scoring. I'm not sure whether that's worth tackling now. One way out would be to not strip stack traces other than the...
jcheng5 pushed 1 commit to deep-stack-limit rstudio/shiny
- Make stack trace stripping work across deep stacks 16b5b31
jcheng5 pushed 1 commit to deep-stack-limit rstudio/shiny
- Remove vector indices from snapshot 2dbb59a
jcheng5 created a review comment on a pull request on rstudio/shiny
Oh, `elide_position` meaning, elide starting at that position. That's not bad