Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jcheng5 pushed 1 commit to main r-lib/later
- Fix run now errors and interrupts (#192) * Fix error/interrupt handling logic to work with Rcpp 1.0.10+ The intro... e7bcc1b
jcheng5 closed an issue on r-lib/later
Error handling is no longer correct
Multiple tests in `test-run_now.R` are failing; we didn't catch this because they're disabled on ci. In `test-run_now.R`, there are tests that test what happens if a callback: 1. throws an er...
jcheng5 created a comment on an issue on jcheng5/r-sidebot
That error is due to an elmer dependency that is not in the DESCRIPTION file, you can get around it for now by doing `pak::pak("r-lib/later")` and restarting R. Sorry for the inconvenience.
jcheng5 created a comment on a pull request on rstudio/promises
WARNING: Some of these async tests can fail and not fail testthat, resulting in blue checks! [Example](https://github.com/rstudio/promises/actions/runs/11980255378/job/33404157340#step:5:41)
jcheng5 pushed 1 commit to domain-reentry rstudio/promises
- Re-enter domains when handlers are called When a handler is subscribed to a promise (using then() or similar) and a ... d42057c
jcheng5 opened a pull request on rstudio/promises
Fix bug where domains aren't re-entered when handlers are executed
Fixes https://github.com/tidyverse/elmer/issues/163
jcheng5 created a review comment on a pull request on r-lib/later
In that case, my very last question (hopefully)... `invoke_wrapped()` calls `invoked()`, which now includes `unwindProtect`/`BEGIN_CPP`. Does it make more sense to have `invoked_wrapped()` continue...
jcheng5 created a review comment on a pull request on r-lib/later
Do we even need this branch at this point? Is `RCPP_USING_UNWIND_PROTECT` entirely up to us? (I think I misunderstood it as being something configured when Rcpp is installed, but my updated underst...
jcheng5 created a review comment on a pull request on r-lib/later
Ohhhh, that makes so much sense when you lay it out like that. Sounds great. If the Windows x86 problem isn't new, then I don't have a problem shipping this at all. Thanks!
jcheng5 pushed 1 commit to fix-run-now-errors-and-interrupts r-lib/later
- Adds unwindProtect (#196) * use Rcpp::uwindProtect() * remove unwindProtect for Rcpp::function; update std::funct... f865884
jcheng5 closed a pull request on r-lib/later
Adds unwindProtect
For our `std::function` callbacks. As discussed in #192. This PR targets your fix branch @jcheng5.
jcheng5 created a review comment on a pull request on r-lib/later
In my hacking last night I was just barely able to get the C++ test (`throw std::runtime_error("This is a C++ exception.");`) to pass on 32 bit, by putting `BEGIN_CPP`/`END_CPP` inside `oof()`. (Or...
jcheng5 created a comment on an issue on tidyverse/elmer
Repro: <details> ```r library(shiny) library(bslib) library(shinychat) library(elmer) ui <- page_fluid( chat_ui("chat") ) server <- function(input, output, session) { get_user_timezone <- f...
jcheng5 created a comment on a pull request on r-lib/later
@shikokuchuo Due to a record-setting windstorm here, I have no access to Windows at the moment; my only Windows PC is a desktop and I have to leave the house with my laptop to have internet. I also...
jcheng5 created a review comment on a pull request on r-lib/later
@shikokuchuo Yes, sorry, I did mean for R 4.1 and earlier on Windows 32-bit.
jcheng5 created a review comment on a pull request on r-lib/later
This is all super helpful. @shikokuchuo other than disabling unwind protect, have you found a usage of `unwindProtect()` that fixes my example here? https://github.com/r-lib/later/pull/192#issuecom...
jcheng5 created a comment on a pull request on posit-dev/py-shinywidgets
In case I didn't say this out loud when we met today, LGTM after you address those last little comments.