Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jcheng5 created a comment on a pull request on tidyverse/elmer
API looks fine to me, I don't have much of an opinion here.
jcheng5 created a comment on a pull request on shikokuchuo/curl
I don't have permissions to officially review this PR, but LGTM 👍
jcheng5 created a comment on a pull request on shikokuchuo/curl
I no longer have an opinion either. My suggestion to avoid changes in curl altogether was based on a mistaken assumption that it was possible to pass in a pre-existing `pool` when creating the `...
jcheng5 created a comment on a pull request on posit-dev/py-shiny
Oh I forgot to mention how I solved the scary error message: by defaulting the websocket logger to `CRITICAL`. In theory this could squash legit error messages (that are specific to auto-reloading)...
jcheng5 pushed 1 commit to websockets-14-0 posit-dev/py-shiny
- Slight code formatting, to minimize diff 3ac6ef0
jcheng5 pushed 1 commit to websockets-14-0 posit-dev/py-shiny
- Simplify loglevel setting No need to pass through to the background thread, we can just change the loglevel on the m... 4e186ac
jcheng5 pushed 1 commit to websockets-14-0 posit-dev/py-shiny
- Tweak autoreload logic to be compatible with websockets>=13.0 5d6c449
jcheng5 pushed 1 commit to websockets-14-0 posit-dev/py-shiny
- Squelch spurious autoreload errors ad9995d
jcheng5 opened a draft pull request on posit-dev/py-shiny
websockets 14.0 support
See #1766 The websockets package released 14.0 which breaks us when using `shiny run --reload`. * As @gadenbuie noticed, the [`process_requests` callback has changed](https://websockets.readt...
jcheng5 created a review comment on a pull request on shikokuchuo/httr2
🤦♂️ Good catch, thanks. I can’t seem to accept the suggestion on my phone but I’ll fix it when I’m at a computer
jcheng5 pushed 1 commit to later_fd shikokuchuo/httr2
- Add (failing) test that private later loops work properly 9e146bd
jcheng5 created a review comment on a pull request on shikokuchuo/httr2
Ah, OK. I'm 99.9% sure it's better to use the current loop here (but 50/50 on what's better for future_promise). @shikokuchuo if you make me a collaborator on your httr2 fork I'll push a unit test ...