Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
I started with it as a class method, but you have to have a class instance to call a class method and this returns a class instance from nothing. I remove the `cls` input so the user can just call ...
jaredthomas68 pushed 1 commit to save-output jaredthomas68/GreenHEART
- remove unnecessary input to and update doc string for and abb2f2e
jaredthomas68 pushed 1 commit to offshore-development jaredthomas68/Ard
- verify that jax AD works with smooth max and min f9119bb
jaredthomas68 pushed 31 commits to save-output jaredthomas68/GreenHEART
- Merge pull request #38 from NREL/develop Release: v0.1.3 ad7d7c8
- Enhancement: Update issue and PR templates (#35) * update PR template to be a bit more relevant * udpate the bug ... a0cc817
- fix bad merge conflict resolution from ad7d7c8 (#40) 055119f
- update jupyter examples for HOPP 3.1.1 (#76) 25baf8f
- LCA Integration (#56) Add and refine LCA calculations, integrate into post-processing, and update examples with LCA ... f075565
- Create the GH Pages Site and Enable a Documentation CI Pipeline (#78) * add CI and update docs to be only GreenHEART 531fa74
- bump version for release 10e0138
- Revert "bump version for release" This reverts commit 10e013899d1bc8bb4d75ad550e7ae062c0e60493. 1c0c9b3
- Add initial new GreenHEART documentation (#72) * Enhancement: Update issue and PR templates (#35) * update PR templ... d9a36d9
- Update CHANGELOG.md 52c3b6c
- bump version and indicate release date 5bf5932
- Removing electrolyzer references that snuck back in 206478e
- Add dependency: CoolProp (#42) * add CoolProp to pyproject.toml * fix typo 0f84a04
- Bugfix: correct LCOE units in OpenMDAO HOPP wrapper (#43) * correct units for lcoe_real in HOPPComponent 7afa4d0
- Putting back CI changes a6ad8da
- Add `pre-commit` workflow for automated linting and formatting (#57) * create pre-commit workflow * run isort and b... 3dcfb17
- update git blame post merge 5b97bc6
- Financial update: steel/ammonia plant cost year updated to 2022 and updates to work with HOPP 3.1.1 (#58) * update d... ff837dd
- Feedstock transport costs (carbon, lime, iron ore pellet) (#59) * include option to specify feedstock transport cost... b1530f5
- add weighted average financial parameter function (#60) * add weighted average parameter function * start applyin... a266592
- and 11 more ...
jaredthomas68 opened a pull request on NREL/GreenHEART
Save output
<!-- IMPORTANT NOTES 1. Use GH flavored markdown when writing your description: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-githu...
jaredthomas68 pushed 1 commit to save-output jaredthomas68/GreenHEART
- update changelog and docstring eeee54b
jaredthomas68 pushed 1 commit to save-output jaredthomas68/GreenHEART
- revert openmdao.py changes e831016
jaredthomas68 pushed 1 commit to save-output jaredthomas68/GreenHEART
- revert steel.py changes 30cc59e
jaredthomas68 created a comment on an issue on WISDEM/Ard
I went ahead and implemented the overflow-proof version of the smooth max. I am able to replicate your output without the need for the hard-coded overflow parameter. Are you ok with me using the ve...
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
Also on the same line, I think `refurb` in profast is supposed to be a percent of the initial capex, but here it looks like we are giving it actual costs in dollar values. Am I missing something?
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
Could be useful now. Let's keep this even if we are not using it yet.
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
The rest of the functions in this file are not used I don't think and should probably be in a different PR. Also, we are somewhat tied with financial naming conventions. These functions require spe...
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
Again, not used so should probably be in a different PR
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
This could be useful, but is not used. Let's hold off on this until we are ready to use it if it is not too hard.
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
I'm ok with adding this function, but it should be applied in the `get_capex` function where I already put the same functionality
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
`update_params_based_on_defaults` and `update_defaults` are not used. Let's remove them.
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
same problem here as with the capex, we need to make sure the costs are discounted, preferably in the same place and way the other costs are discounted.
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
This check feels out of place here. I think the checkout should be done in the electrolyzer costing and set to zero there if needed.