Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jaredthomas68 created a comment on a pull request on NREL/HOPP
I'd like to get this in ASAP for P2N. Only thing I see missing is that there are no tests around this.
jaredthomas68 created a comment on a pull request on NREL/GreenHEART
> In terms of LCA methodology, the utilities.py script looks good (haven't tested it though). I am aware you made some tests for comparison between GREET and the script so, please, make sure you ha...
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
the "Assessment" and "analysis" are redundant. Also, can you clarify what the little "e" means for readers? Otherwise this looks fine.
jaredthomas68 created a review on a pull request on NREL/GreenHEART
I am generally on board with this PR. I agree with @kbrunik and @jmartin4nrel that a lot of this should be written in a less manual way. It is very easy for bugs to creep in unnoticed in the way t...
jaredthomas68 pushed 1 commit to develop NREL/GreenHEART
- add weighted average financial parameter function (#60) * add weighted average parameter function * start applyin... 104d099
jaredthomas68 closed a pull request on NREL/GreenHEART
add weighted average financial parameter function
<!-- IMPORTANT NOTES 1. Use GH flavored markdown when writing your description: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-githu...
jaredthomas68 pushed 1 commit to weighted-average-financials jaredthomas68/GreenHEART
- remove debugging code 84db345
jaredthomas68 pushed 1 commit to weighted-average-financials jaredthomas68/GreenHEART
- update changelog 9e7fc1f
jaredthomas68 pushed 1 commit to weighted-average-financials jaredthomas68/GreenHEART
- apply financial parameter averaging to debt/equity split and ratio 253965c
jaredthomas68 pushed 1 commit to weighted-average-financials jaredthomas68/GreenHEART
- apply weighted average parameter function to equity discount rate 36c27c3
jaredthomas68 pushed 3 commits to weighted-average-financials jaredthomas68/GreenHEART
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
This is a good point, but I'm not planning on users knowing it exists. I'm working on putting the implementation in for each parameter I want it applied to in the financial models. I just did not w...
jaredthomas68 opened a draft pull request on NREL/GreenHEART
add weighted average financial parameter function
<!-- IMPORTANT NOTES 1. Use GH flavored markdown when writing your description: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-githu...
jaredthomas68 pushed 1 commit to develop NREL/GreenHEART
- Feedstock transport costs (carbon, lime, iron ore pellet) (#59) * include option to specify feedstock transport cost... 6864533
jaredthomas68 closed a pull request on NREL/GreenHEART
Feedstock transport costs (carbon, lime, iron ore pellet)
<!-- IMPORTANT NOTES 1. Use GH flavored markdown when writing your description: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-githu...
jaredthomas68 created a comment on a pull request on NREL/GreenHEART
> All looks good. (1) One minor thing: the transportation costs (lines 66, 68 and 71) are in per-tonne of feedstock. These are added to the unit costs which are also expressed in per-tonne. (2) Als...
jaredthomas68 pushed 1 commit to feedstock-transport jaredthomas68/GreenHEART
- update units for steel feedstocks in comments fe3f89d
jaredthomas68 pushed 1 commit to feedstock-transport jaredthomas68/GreenHEART
- update steel tests to account for updates to hopp and steel cost year (2022) ee8e419
jaredthomas68 pushed 2 commits to feedstock-transport jaredthomas68/GreenHEART