Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jaredthomas68 pushed 1 commit to develop NREL/HOPP
- Feature/profast fin model (#355) * add lcoe calculations to the custom financial model using profast * fix loggin... 9b856a8
jaredthomas68 closed a pull request on NREL/HOPP
Feature/profast fin model
<!-- IMPORTANT NOTES Is this pull request ready to be merged? - Do the existing tests pass and new tests added for new code? - Is all development in a state where you are proud to share it wi...
jaredthomas68 created a comment on a pull request on NREL/HOPP
> Thanks @kbrunik! Is this ready to be merged in @jaredthomas68 or are you planning any further modifications? Could you please make issues for any upcoming changes that need to happen that are not...
jaredthomas68 created a review comment on a pull request on NREL/HOPP
I'm going to go ahead and merge, but we can continue this discussion in PR #387
jaredthomas68 opened an issue on NREL/HOPP
Feature request: reconsider how operation and maintenance are passed to ProFAST
<!-- IMPORTANT NOTES Thank you for taking the time to suggest a feature. Before submitting, please reread your description to ensure that other readers can reasonably understand the motivatio...
jaredthomas68 created a review comment on a pull request on NREL/HOPP
I have created an issue to continue this discussion: #402
jaredthomas68 opened an issue on NREL/HOPP
Feature request: Allow ProFAST wrapper to use either production or nameplate capacity with capacity factor
<!-- IMPORTANT NOTES Thank you for taking the time to suggest a feature. Before submitting, please reread your description to ensure that other readers can reasonably understand the motivatio...
jaredthomas68 created a review comment on a pull request on NREL/HOPP
I have submitted an issue for this discussion to continue: #401
jaredthomas68 pushed 1 commit to feature/profast-fin-model jaredthomas68/HOPP
- remove commented code 3166970
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
I like where things are at now, but we should remove the comment about replacing "<>" blocks since it is irrelevant.
jaredthomas68 pushed 1 commit to feature/profast-fin-model jaredthomas68/HOPP
- update revenue doc strings 78c4fd6
jaredthomas68 pushed 1 commit to feature/profast-fin-model jaredthomas68/HOPP
- update FinancialParameters doc string 577e061
jaredthomas68 created a review comment on a pull request on NREL/HOPP
I agree, but I consider the o_and_m_cost to be a separate issue as it impacts all financial models.
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
I think generally the `<!- >` blocks are more useful since they can be left in the raw file but do not render. Also, the replacement direction is a little confusing since `<!-- >` is a subset of `<...
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
Why are the electrolyzer changes I already made showing up in this PR?
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
"If not, and this is expected[,] please ...."
jaredthomas68 created a review comment on a pull request on NREL/GreenHEART
"If all [boxes] in the PR Checklist cannot be [checked]..."