Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
hicder created a review comment on a pull request on hicder/muopdb
my personal preference is also to have 2 functions: `write_to_metadata_mmaps` and `write_to_posting_list_mmaps`, that internally just calls this function. It's extra, but it makes things easy to re...
hicder created a review comment on a pull request on hicder/muopdb
for readability, create 2 functions: ``` fn new_metadata_backing_file(&mut self); fn new_posting_list_backing_file(&mut self); ``` Each of them will call `self.new_backfing_file({true, false...
hicder created a review comment on a pull request on hicder/muopdb
the name of the function should tell you what it does. `get_slice` is not very clear what is the purpose of this function
hicder created a review comment on a pull request on hicder/muopdb
put the output at the end. change `offset` to `total_length` (which is how I understand this code). Change `backing_file_size` to `individual_backing_file_size` ```suggestion fn write_all_m...
hicder created a review comment on a pull request on hicder/muopdb
I think it might be worth it if you create a struct like this: ``` struct MMapsInfo { pub mmaps: Vec<...>, pub current_overall_offset: usize, } ``` then, in ``` struct FileBacke...
hicder created a review comment on a pull request on hicder/muopdb
refactor this to a different function for readability
hicder closed a pull request on hicder/muopdb
Reorganize the quantization directory
No code change, just move files around
hicder opened a pull request on hicder/muopdb
Reorganize the quantization directory
No code change, just move files around
hicder created a review comment on a pull request on hicder/muopdb
I feel like the logic to extract information from both metadata and posting list files are the same. Maybe there is a way to reuse the code here? * Get the overall offset * From the overall offset,...
hicder created a review comment on a pull request on hicder/muopdb
similarly, there might be a way to reuse the code between metadata and posting lists?
hicder created a review comment on a pull request on hicder/muopdb
maybe refactor to a separate function for readability
hicder created a review comment on a pull request on hicder/muopdb
use a different name a well. whose size is this? otherwise, just inline the variable
hicder created a review comment on a pull request on hicder/muopdb
use different name. The name should indicate what this variable is for.
hicder created a review comment on a pull request on hicder/muopdb
please don't use tuple, very hard to tell which is which.