Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

hayes-mysten

hayes-mysten deleted a branch MystenLabs/sui

mh--always-add-legacy-account

hayes-mysten closed a pull request on MystenLabs/sui
[wallet] Always add legacy accounts
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your cha...
hayes-mysten created a review comment on a pull request on MystenLabs/sui
somehow the history check also disappeared from the other PR

View on GitHub

hayes-mysten created a review on a pull request on MystenLabs/sui

View on GitHub

hayes-mysten opened a pull request on MystenLabs/sui
[wallet] Always add legacy accounts
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your cha...
hayes-mysten created a branch on MystenLabs/sui

mh--always-add-legacy-account - Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language

hayes-mysten deleted a branch MystenLabs/sui

tlmysten/zklogin-legacy-accounts

hayes-mysten pushed 1 commit to main MystenLabs/sui
  • import legacy/non-legacy zklogin accounts (#20632) ## Description Describe the changes or additions included in ... 08dfeb1

View on GitHub

hayes-mysten closed a pull request on MystenLabs/sui
import legacy/non-legacy zklogin accounts
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your cha...
hayes-mysten created a review on a pull request on MystenLabs/sui

View on GitHub

hayes-mysten created a review comment on a pull request on MystenLabs/sui
the todo and `_` can be removed now right?

View on GitHub

hayes-mysten created a review on a pull request on MystenLabs/sui

View on GitHub

hayes-mysten created a review comment on a pull request on MystenLabs/sui
Whats the expected behavior when unlocking? I think if we are unlocking both accounts we don't need this check, but if we aren't unlocking the alternative accounts we probably don't need to save t...

View on GitHub

hayes-mysten created a review on a pull request on MystenLabs/sui

View on GitHub

hayes-mysten created a review comment on a pull request on MystenLabs/sui
Do we need something like this here too? ```suggestion const [newAccount] = await addNewAccounts([ { address, createdAt: Date.now(), publicKey: cached.publicKey, ...

View on GitHub

hayes-mysten created a review on a pull request on MystenLabs/sui

View on GitHub

hayes-mysten created a review comment on a pull request on MystenLabs/sui
```suggestion return !!txnIds.data.length || !!fromTxnIds.data.length; ```

View on GitHub

hayes-mysten created a review on a pull request on MystenLabs/sui

View on GitHub

hayes-mysten pushed 1 commit to main MystenLabs/sui
  • [wallet] fix issue where we incorrectly compute the non-legacy zklogi… (#20628) …n address in the wallet ## Descr... db834d8

View on GitHub

hayes-mysten deleted a branch MystenLabs/sui

mh--compute-correct-zklogin-address

hayes-mysten closed a pull request on MystenLabs/sui
[wallet] fix issue where we incorrectly compute the non-legacy zklogi…
…n address in the wallet ## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes ...
hayes-mysten opened a pull request on MystenLabs/sui
[wallet] fix issue where we incorrectly compute the non-legacy zklogi…
…n address in the wallet ## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes ...
hayes-mysten created a branch on MystenLabs/sui

mh--compute-correct-zklogin-address - Sui, a next-generation smart contract platform with high throughput, low latency, and an asset-oriented programming model powered by the Move programming language

hayes-mysten pushed 1 commit to main MystenLabs/sui
  • Version Packages (#20587) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitH... e86b98b

View on GitHub

hayes-mysten deleted a branch MystenLabs/sui

changeset-release/main

hayes-mysten closed a pull request on MystenLabs/sui
Version Packages
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this ...
hayes-mysten created a review on a pull request on MystenLabs/sui

View on GitHub

hayes-mysten created a review on a pull request on MystenLabs/sui

View on GitHub

hayes-mysten created a review comment on a pull request on MystenLabs/sui
not as its written. Anything after `this.#options.authenticatorSelection` will be overwritten. Basically it should be `{ defaultOption: 123, ...userProvidedOptions, optionWeDontWantUserToOverwri...

View on GitHub

hayes-mysten created a review on a pull request on MystenLabs/sui

View on GitHub

Load more