Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
grejdi-mbta created a review comment on a pull request on mbta/data_platform
Refactored due to a Credo warning.
grejdi-mbta pushed 1 commit to gg-update-elixir mbta/data_platform
- chore: update elixir to 1.18 55cccc4
grejdi-mbta pushed 1 commit to gg-update-elixir mbta/data_platform
- chore: update elixir to 1.18 e64c8a2
grejdi-mbta pushed 1 commit to gg-update-elixir mbta/data_platform
- chore: update elixir to 1.18 8ca1372
grejdi-mbta created a review on a pull request on mbta/dmap-import
Excellent! I'd love for you to document it more. I guess the PR description captures that. But I find that bringing that into the code as a comment would be better.
grejdi-mbta created a review comment on a pull request on mbta/dmap-import
If it is just a table to load stuff, maybe truncating at the end as well? I want it to be obvious that it shouldn't be used by data analysts.
grejdi-mbta created a review comment on a pull request on mbta/dmap-import
update comment here. q: is `_load` a new type of table at this point? we need to communicate to folks who are using the database what it is, so they can ignore if need be.
grejdi-mbta created a review on a pull request on mbta/dmap-import
Please make sure to test the error bucket addition.
grejdi-mbta created a review comment on a pull request on mbta/dmap-import
Up to you. But I think we should have it in there. The glue pipeline is unnecessarily strict so we shouldn't constrain this pipeline because of it.
grejdi-mbta created a review comment on a pull request on mbta/data_platform
You forgot `is_active: true,`. See https://www.notion.so/mbta-downtown-crossing/Adding-a-New-Table-for-Ingestion-ec2f44a98f864a18929e4db4b48c931a
grejdi-mbta pushed 2 commits to main mbta/dmap-import