Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
giunatale created a comment on a pull request on atomone-hub/atomone
since this work was left untouched for a while, we need to give it a final pass to identify potentially missing tests and check test coverage, and add documentation. Ideally we would also want to d...
giunatale pushed 1 commit to giunatale/gov/dynamic-deposit atomone-hub/atomone
- use common variables 1d88928
giunatale pushed 19 commits to governors-no-aggregate-vp giunatale/atomone
- Create RELEASES.md 5541b95
- Update README.md cb4dc6b
- chore: improve Makefile and release docs (#37) Closes #32 Improvement list: - remove `build-linux` that breaks ... 2b60d1c
- doc: replace registry link (#36) a9ad7c9
- chore: add info log when building with Ledger support disabled (#40) Add an info log line when building without ledg... 5c8e656
- fix: swagger generation (#38) Closes: #35 The swagger generation consists of the following steps: - generate jso... c445115
- chore: update README (#48) As the title says, update README to remove mentioning of IBC and ICA being deleted while... 768b03e
- chore: fix typo (#52) fix typo daa8dfd
- fix(vuln): https://pkg.go.dev/vuln/GO-2024-3279 (#60) Spotted by `make vulncheck` Last seen in https://github.com/a... 4a894e1
- chore: bump go to 1.22 (#61) Go is being carefully upgraded in SDK chains because of issues with state sync between ... 3456257
- fix(vuln): GO-2024-3112 and GO-2024-2951 (#62) Upgrade cometbft from v0.37.5 to v0.37.13 (latest v0.37) to fix 2 vul... df1eefe
- chore(gov): override MinVotingPeriod with ldflags (#63) Also updated makefile so that a custom voting period can be... 3ad3d32
- chore: rename makefile VOTING_PERIOD (#64) VOTING_PERIOD is not the correct term, the change renames it to MIN_VOTIN... 1f363d5
- fix(vuln): GHSA-8wcc-m6j2-qxvm (#67) Close #66 Upgrade cosmos-sdk to v0.47.15 to patch security issue ASA-2024-0012... 9723aff
- docs: ADR-002 The Photon Token (#34) First draft of the ADR to be reviewed. I left a few comments for reviewers a... f7d541e
- feat: add `x/photon` module (#57) This PR adds the `x/photon` module to the main branch, which implements the corre... fd62df9
- docs: ADR-003 Governance Proposal Deposit Auto-Throttler (#65) ADR for the implementation of the min deposit throttl... e8cad6e
- Merge branch 'main' into governors-no-aggregate-vp 3d4fc3f
- fix merge conflicts 2713498
giunatale pushed 34 commits to giunatale/gov/dynamic-deposit atomone-hub/atomone
- fix(vuln): https://pkg.go.dev/vuln/GO-2024-3279 (#60) Spotted by `make vulncheck` Last seen in https://github.com/a... 4a894e1
- chore: bump go to 1.22 (#61) Go is being carefully upgraded in SDK chains because of issues with state sync between ... 3456257
- fix(vuln): GO-2024-3112 and GO-2024-2951 (#62) Upgrade cometbft from v0.37.5 to v0.37.13 (latest v0.37) to fix 2 vul... df1eefe
- chore(gov): override MinVotingPeriod with ldflags (#63) Also updated makefile so that a custom voting period can be... 3ad3d32
- chore: rename makefile VOTING_PERIOD (#64) VOTING_PERIOD is not the correct term, the change renames it to MIN_VOTIN... 1f363d5
- fix(vuln): GHSA-8wcc-m6j2-qxvm (#67) Close #66 Upgrade cosmos-sdk to v0.47.15 to patch security issue ASA-2024-0012... 9723aff
- docs: ADR-002 The Photon Token (#34) First draft of the ADR to be reviewed. I left a few comments for reviewers a... f7d541e
- feat: add `x/photon` module (#57) This PR adds the `x/photon` module to the main branch, which implements the corre... fd62df9
- docs: ADR-003 Governance Proposal Deposit Auto-Throttler (#65) ADR for the implementation of the min deposit throttl... e8cad6e
- prototype `GetCurrentMinDeposit` d516277
- move prototype to separate file 4f6b7a7
- draft implementation, still missing pieces 383396d
- add ways to activate proposals when deposit decreases a305b76
- make deposit stay stable when at target e43d85a
- improve GetMinDeposit c0ba785
- add mindeposit query 48ae048
- add params validation f21be70
- params ec45133
- genesis 47fdc95
- move out code from keeper.SetParams 55fa158
- and 14 more ...
giunatale pushed 1 commit to main atomone-hub/atomone
- docs: ADR-003 Governance Proposal Deposit Auto-Throttler (#65) ADR for the implementation of the min deposit throttl... e8cad6e
giunatale closed a pull request on atomone-hub/atomone
docs: ADR-003 Governance Proposal Deposit Auto-Throttler
ADR for the implementation of the min deposit throttling, with notes on also the min initial deposit. Implementation is at https://github.com/atomone-hub/atomone/pull/69 [Rendered version](ht...
giunatale pushed 1 commit to giunatale/gov/dynamic-deposit atomone-hub/atomone
- feat(x/gov): add dynamic min initial deposit (#72) This PR replicates the dynamic system implemented for the `MinDep... 78815ff
giunatale closed a pull request on atomone-hub/atomone
feat(x/gov): add dynamic min initial deposit
This PR replicates the dynamic system implemented for the `MinDeposit` also for `MinInitialDeposit`. For proposals submissions now, since the `MinInitialDeposit` can be lower or higher than the ...
giunatale closed an issue on atomone-hub/atomone
Photon implementation
From the AtomOne Constitution [Article 3 Section 5](https://github.com/atomone-hub/genesis/blob/main/CONSTITUTION.md#section-5-the-photon-token) > Section 5: The PHOTON Token > The PHOTON shall...
giunatale pushed 1 commit to main atomone-hub/atomone
- feat: add `x/photon` module (#57) This PR adds the `x/photon` module to the main branch, which implements the corre... fd62df9
giunatale closed a pull request on atomone-hub/atomone
feat: add `x/photon` module
This PR adds the `x/photon` module to the main branch, which implements the corresponding ADR (separate PR #34) Closes #44
giunatale closed a pull request on giunatale/atomone
x/gov: remove aggregate VP for governors
change also the governors election logic, now only voting governors are counted removes a lot of logic that could cause performance issues
giunatale pushed 1 commit to main atomone-hub/atomone
- docs: ADR-002 The Photon Token (#34) First draft of the ADR to be reviewed. I left a few comments for reviewers a... f7d541e
giunatale closed a pull request on atomone-hub/atomone
docs: ADR-002 The Photon Token
First draft of the ADR to be reviewed. I left a few comments for reviewers after the `XXX` symbol. Also updated the `adr-template` because it was using the windows file format. [Rendered v...
giunatale created a review comment on a pull request on atomone-hub/atomone
The floor value is just the starting point and the "equilibrium" might be found at another value. This could also depend on the price of the token itself for example. Per-message deposit might beco...
giunatale created a review comment on a pull request on atomone-hub/atomone
I don't know if I agree. I think it should remain a percentage of the MinDeposit. Can you explain your reasoning? To me, if we assume the dynamic system is a way of pricing deposits then if th...
giunatale created a review comment on a pull request on atomone-hub/atomone
same comment as above, I see no issues with this. It's a way as any other
giunatale created a review comment on a pull request on atomone-hub/atomone
Either way it's the same to me, very little change imho.
giunatale created a review comment on a pull request on atomone-hub/atomone
Not sure I follow, I don't see anything bad with this. It's just a way as any other to assign a floor value
giunatale created a review comment on a pull request on atomone-hub/atomone
There are other parts where I commented code instead of removing it. I don't know about removing it but if you really feel it be necessary, all the commented code should be removed for consistency....
giunatale created a review comment on a pull request on atomone-hub/atomone
I guess it's a matter of preference. I prefer it this way
giunatale created a review comment on a pull request on atomone-hub/atomone
I don't think it improves anything tbh. I would rather pass the individual terms or i would have changed it.