Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
giunatale pushed 1 commit to giunatale/gov/dynamic-deposit atomone-hub/atomone
- make deposit stay stable when at target e9d5c79
giunatale created a branch on atomone-hub/atomone
giunatale/gov/dynamic-deposit - AtomOne chain software
giunatale opened a pull request on atomone-hub/atomone
feat: add `x/photon` module
This PR adds the `x/photon` module to the main branch, which implements the corresponding ADR (separate PR #34) Closes #44
giunatale pushed 1 commit to feat/photon atomone-hub/atomone
- feat(x/photon): mint photon message (#53) Relates to #44 This PR adds a new message `MsgMintPhoton` inside a new ... 8ecfade
giunatale closed a pull request on atomone-hub/atomone
feat(x/photon): mint photon message
Relates to #44 This PR adds a new message `MsgMintPhoton` inside a new `x/photon` module. List of changes: - `x/photon` queries : `params` & `conversion_rate` - `x/photon` transaction: `MsgMi...
giunatale created a review comment on a pull request on atomone-hub/atomone
```suggestion expected to never be able to fail because of insufficient mintable PHOTONs. There is however still a need to check that after calculations the amount of photons to mint is non-z...
giunatale created a review comment on a pull request on atomone-hub/atomone
I would have still added the check here too but ok, I guess we'll check with a live test if this is a problem or not. I think you are right but let's see. Closing for now
giunatale created a review comment on a pull request on atomone-hub/atomone
The first error can indeed happen due to rounding issue so it should stay, but the second check can be safely removed as agreed.
giunatale created a review comment on a pull request on atomone-hub/atomone
check also that there is a non-zero amount for the denom coin
giunatale created a review comment on a pull request on atomone-hub/atomone
```suggestion // If no photon to mint, do not burn bondDenomToBurn, returns an error // this could happen due to rounding ```
giunatale created a review comment on a pull request on atomone-hub/atomone
Both checks but especially the second could be avoided. The second one especially, considering you get the conversionRate and its implicit photonToMint + photonSupply <= photonMaxSupply because th...
giunatale pushed 1 commit to tbruyelle/docs/relayer-upgrade atomone-hub/atomone
- add denom to update docs 676bd8b
giunatale created a review comment on a pull request on atomone-hub/atomone
```suggestion denom (`uphoton`) for the fees, **before** the upgrade, see [Validator config ```
giunatale pushed 1 commit to tbruyelle/feat/photon-module atomone-hub/atomone
- feat(x/photon): validate fee ante decorator (#54) Relates to #44 This PR adds a `sdk.AnteDecorator` implementati... 4563e66
giunatale closed a pull request on atomone-hub/atomone
feat(x/photon): validate fee ante decorator
Relates to #44 This PR adds a `sdk.AnteDecorator` implementation in `x/photon/ante` and adds it to the list of the app ante decorators. This new ante decorator ensures that photon is the fee to...
giunatale pushed 1 commit to tbruyelle/feat/photon-tx-fee-checker atomone-hub/atomone
- feat(x/photon): migration (#55) Relates to #44 - perform module migration to add the photon module in the upgrade... 24a15ad
giunatale closed a pull request on atomone-hub/atomone
feat(x/photon): migration
Relates to #44 - perform module migration to add the photon module in the upgrade module version map - register the photon denom metata in the bank module - add a storeloader for the photon mo...
giunatale created a review on a pull request on atomone-hub/atomone
Quite more extensive than what initially seemed to be. Mostly lots of changes required for tets and the issue with simulation. One note, "Excepted" is rarely used and rarely I see it, I would us...